Bug 1362100 - Ensure bookmark toolbar button dropmarker icon remains correct size while animating. r=dao draft
authorNihanth Subramanya <nhnt11@gmail.com>
Fri, 05 May 2017 18:43:23 +0530
changeset 573324 74cbac351fe96277441fc0252fc4b1ba3e4521b8
parent 572730 0b255199db9d6a6f189b89b7906f99155bde3726
child 627253 8292748c0ac6c0da6eddc0f979e505b179d9a757
push id57338
push usernhnt11@gmail.com
push dateFri, 05 May 2017 14:06:24 +0000
reviewersdao
bugs1362100
milestone55.0a1
Bug 1362100 - Ensure bookmark toolbar button dropmarker icon remains correct size while animating. r=dao The actual dropmarker's list-style-image was forced to none while animating, with another one overlayed on top of it. Setting fill: transparent; accomplishes the goal of hiding the default icon without affecting layout. MozReview-Commit-ID: 9AhlfYR9SV9
browser/themes/shared/bookmarked-notification.inc.css
--- a/browser/themes/shared/bookmarked-notification.inc.css
+++ b/browser/themes/shared/bookmarked-notification.inc.css
@@ -51,17 +51,17 @@
 
 @media (min-resolution: 2dppx) {
   #bookmarked-notification-anchor[notification="finish"] > #bookmarked-notification {
     background-image: url("chrome://browser/skin/places/bookmarks-notification-finish@2x.png");
   }
 }
 
 #bookmarks-menu-button[notification="finish"] > .toolbarbutton-menubutton-dropmarker > .dropmarker-icon {
-  list-style-image: none !important;
+  fill: transparent;
 }
 
 #bookmarked-notification-dropmarker-anchor[notification="finish"] > #bookmarked-notification-dropmarker-icon {
   visibility: visible;
   animation: animation-bookmarkPulse 300ms;
   animation-delay: 600ms;
   animation-timing-function: ease-out;
 }