Bug 1351795 - part 1: Remove console.timeline and timelineEnd. r=baku draft
authorbtian <btian@mozilla.com>
Tue, 09 May 2017 11:39:27 +0800
changeset 574645 43b55175f9ba1671e8269a227078e205581c8f1c
parent 574519 b21b974d60d3075ae24f6fb1bae75d0f122f28fc
child 574646 3f620c05faf82731d384dfca369db62ae8eb871e
push id57785
push userbmo:btian@mozilla.com
push dateTue, 09 May 2017 07:34:40 +0000
reviewersbaku
bugs1351795
milestone55.0a1
Bug 1351795 - part 1: Remove console.timeline and timelineEnd. r=baku MozReview-Commit-ID: DLoqGD5NDwt
addon-sdk/source/lib/sdk/content/sandbox.js
dom/tests/mochitest/general/test_consoleAPI.html
dom/webidl/Console.webidl
testing/web-platform/meta/console/console-timeline-timelineEnd-historical.any.js.ini
--- a/addon-sdk/source/lib/sdk/content/sandbox.js
+++ b/addon-sdk/source/lib/sdk/content/sandbox.js
@@ -255,18 +255,16 @@ const WorkerSandbox = Class({
         profileEnd: genPropDesc('profileEnd'),
         exception: genPropDesc('exception'),
         assert: genPropDesc('assert'),
         count: genPropDesc('count'),
         table: genPropDesc('table'),
         clear: genPropDesc('clear'),
         dirxml: genPropDesc('dirxml'),
         markTimeline: genPropDesc('markTimeline'),
-        timeline: genPropDesc('timeline'),
-        timelineEnd: genPropDesc('timelineEnd'),
         timeStamp: genPropDesc('timeStamp'),
       };
 
       Object.defineProperties(con, properties);
       Cu.makeObjectPropsNormal(con);
 
       win.console = con;
     };
--- a/dom/tests/mochitest/general/test_consoleAPI.html
+++ b/dom/tests/mochitest/general/test_consoleAPI.html
@@ -36,18 +36,16 @@ function doTest() {
     "profile": "function",
     "profileEnd": "function",
     "assert": "function",
     "count": "function",
     "table": "function",
     "clear": "function",
     "dirxml": "function",
     "markTimeline": "function",
-    "timeline": "function",
-    "timelineEnd": "function",
     "timeStamp": "function",
   };
 
   var foundProps = 0;
   for (var prop in console) {
     foundProps++;
     is(typeof(console[prop]), expectedProps[prop], "expect console prop " + prop + " exists");
   }
--- a/dom/webidl/Console.webidl
+++ b/dom/webidl/Console.webidl
@@ -41,20 +41,16 @@ namespace console {
   void timeStamp(optional any data);
 
   void profile(any... data);
   void profileEnd(any... data);
 
   // No-op methods for compatibility with other browsers.
   [BinaryName="noopMethod"]
   void markTimeline();
-  [BinaryName="noopMethod"]
-  void timeline();
-  [BinaryName="noopMethod"]
-  void timelineEnd();
 
   [ChromeOnly]
   const boolean IS_NATIVE_CONSOLE = true;
 };
 
 // This is used to propagate console events to the observers.
 dictionary ConsoleEvent {
   (unsigned long long or DOMString) ID;
deleted file mode 100644
--- a/testing/web-platform/meta/console/console-timeline-timelineEnd-historical.any.js.ini
+++ /dev/null
@@ -1,17 +0,0 @@
-[console-timeline-timelineEnd-historical.any.worker.html]
-  type: testharness
-  ['timeline' function should not exist on the console object]
-    expected: FAIL
-
-  ['timelineEnd' function should not exist on the console object]
-    expected: FAIL
-
-
-[console-timeline-timelineEnd-historical.any.html]
-  type: testharness
-  ['timeline' function should not exist on the console object]
-    expected: FAIL
-
-  ['timelineEnd' function should not exist on the console object]
-    expected: FAIL
-