Bug 1359759 - 1 - Move grid outline below grid details to avoid UI jumps; r=gl draft
authorPatrick Brosset <pbrosset@mozilla.com>
Tue, 25 Apr 2017 18:38:02 +0200
changeset 575520 d6dcdd07aef58e3077a4ad1dd8b17bbcae1c6505
parent 575519 e80d3ec92568b19d8773e8cc3be84cedda10a4d4
child 575521 473ca1e1777d4e14f4f45a0b306b8153775cb1e6
push id58080
push userbmo:pbrosset@mozilla.com
push dateWed, 10 May 2017 15:09:21 +0000
reviewersgl
bugs1359759
milestone55.0a1
Bug 1359759 - 1 - Move grid outline below grid details to avoid UI jumps; r=gl MozReview-Commit-ID: LeUAb6YWVWB
devtools/client/inspector/grids/components/Grid.js
--- a/devtools/client/inspector/grids/components/Grid.js
+++ b/devtools/client/inspector/grids/components/Grid.js
@@ -55,25 +55,16 @@ module.exports = createClass({
       onShowGridLineNamesHighlight,
     } = this.props;
 
     return grids.length ?
       dom.div(
         {
           id: "layout-grid-container",
         },
-        showGridOutline ?
-          GridOutline({
-            grids,
-            onShowGridAreaHighlight,
-            onShowGridCellHighlight,
-            onShowGridLineNamesHighlight,
-          })
-          :
-          null,
         dom.div(
           {
             className: "grid-content",
           },
           GridList({
             getSwatchColorPickerTooltip,
             grids,
             setSelectedNode,
@@ -82,17 +73,26 @@ module.exports = createClass({
             onShowBoxModelHighlighterForNode,
             onToggleGridHighlighter,
           }),
           GridDisplaySettings({
             highlighterSettings,
             onToggleShowGridLineNumbers,
             onToggleShowInfiniteLines,
           })
-        )
+        ),
+        showGridOutline ?
+          GridOutline({
+            grids,
+            onShowGridAreaHighlight,
+            onShowGridCellHighlight,
+            onShowGridLineNamesHighlight,
+          })
+          :
+          null
       )
       :
       dom.div(
         {
           className: "layout-no-grids",
         },
         getStr("layout.noGrids")
       );