Bug 1361547, part 1 - Alphabetically sort existing cases in JS_GetTraceThingInfo(). r=sfink
A comment by TraceKind says to sort alphabetically. Currently, these
cases appear to not be in any particular order.
MozReview-Commit-ID: 3owHBViGUs5
--- a/js/src/gc/Tracer.cpp
+++ b/js/src/gc/Tracer.cpp
@@ -326,54 +326,54 @@ JS_GetTraceThingInfo(char* buf, size_t b
{
const char* name = nullptr; /* silence uninitialized warning */
size_t n;
if (bufsize == 0)
return;
switch (kind) {
- case JS::TraceKind::Object:
- {
- name = static_cast<JSObject*>(thing)->getClass()->name;
- break;
- }
-
- case JS::TraceKind::Script:
- name = "script";
- break;
-
- case JS::TraceKind::String:
- name = ((JSString*)thing)->isDependent()
- ? "substring"
- : "string";
- break;
-
- case JS::TraceKind::Symbol:
- name = "symbol";
- break;
-
case JS::TraceKind::BaseShape:
name = "base_shape";
break;
case JS::TraceKind::JitCode:
name = "jitcode";
break;
case JS::TraceKind::LazyScript:
name = "lazyscript";
break;
+ case JS::TraceKind::Object:
+ {
+ name = static_cast<JSObject*>(thing)->getClass()->name;
+ break;
+ }
+
+ case JS::TraceKind::ObjectGroup:
+ name = "object_group";
+ break;
+
+ case JS::TraceKind::Script:
+ name = "script";
+ break;
+
case JS::TraceKind::Shape:
name = "shape";
break;
- case JS::TraceKind::ObjectGroup:
- name = "object_group";
+ case JS::TraceKind::String:
+ name = ((JSString*)thing)->isDependent()
+ ? "substring"
+ : "string";
+ break;
+
+ case JS::TraceKind::Symbol:
+ name = "symbol";
break;
default:
name = "INVALID";
break;
}
n = strlen(name);