Bug 1361463 - Fix typo in BrowserAction.getPopup, r?kmag draft
authorBob Silverberg <bsilverberg@mozilla.com>
Tue, 02 May 2017 14:55:03 -0400
changeset 571518 9f26a16ee21b773f379ace256f27923ef8d408d6
parent 571414 bfc7b187005cabbc828ed9f5b61daf139c3cfd90
child 574439 e35e494148107ba5cd198b797ea7380c5446ddd0
push id56817
push userbmo:bob.silverberg@gmail.com
push dateTue, 02 May 2017 19:00:21 +0000
reviewerskmag
bugs1361463
milestone55.0a1
Bug 1361463 - Fix typo in BrowserAction.getPopup, r?kmag The if statement in getPopup should read `if (!blockParser)` not `if (!this.blockParser)`. MozReview-Commit-ID: IBtHHS634sG
browser/components/extensions/ext-browserAction.js
--- a/browser/components/extensions/ext-browserAction.js
+++ b/browser/components/extensions/ext-browserAction.js
@@ -316,17 +316,17 @@ this.browserAction = class extends Exten
    */
   getPopup(window, popupURL, blockParser = false) {
     this.clearPopupTimeout();
     let {pendingPopup} = this;
     this.pendingPopup = null;
 
     if (pendingPopup) {
       if (pendingPopup.window === window && pendingPopup.popupURL === popupURL) {
-        if (!this.blockParser) {
+        if (!blockParser) {
           pendingPopup.unblockParser();
         }
 
         return pendingPopup;
       }
       pendingPopup.destroy();
     }