Bug 1361288 - Remove vestigial reference to advancedLongDesc and hide advancedButton for SSLv3 erros. r?johannh
Unfortunately, we can't simply restore advancedLongDesc because it will change strings. I hid advancedButton instead. The advanced panel will have no useful information for SSLv3 errors anyway.
MozReview-Commit-ID: D4ULtTKccOK
--- a/browser/base/content/aboutNetError.xhtml
+++ b/browser/base/content/aboutNetError.xhtml
@@ -103,20 +103,16 @@
}
function setupAdvancedButton() {
// Get the hostname and add it to the panel
var panel = document.getElementById("badCertAdvancedPanel");
for (var span of panel.querySelectorAll("span.hostname")) {
span.textContent = document.location.hostname;
}
- if (!gIsCertError) {
- panel.replaceChild(document.getElementById("errorLongDesc"),
- document.getElementById("advancedLongDesc"));
- }
// Register click handler for the weakCryptoAdvancedPanel
document.getElementById("advancedButton")
.addEventListener("click", function togglePanelVisibility() {
toggleDisplay(panel);
if (gIsCertError) {
// Toggling the advanced panel must ensure that the debugging
// information panel is hidden as well, since it's opened by the
@@ -283,17 +279,17 @@
"SSL_ERROR_NO_CIPHERS_SUPPORTED"
].some((substring) => getDescription().includes(substring));
// If it looks like an error that is user config based
if (getErrorCode() == "nssFailure2" && hasPrefStyleError && options && options.changedCertPrefs) {
showPrefChangeContainer();
}
}
if (getErrorCode() == "sslv3Used") {
- setupAdvancedButton();
+ document.getElementById("advancedButton").style.display = "none";
}
}, true, true);
var event = new CustomEvent("AboutNetErrorLoad", {bubbles: true});
document.dispatchEvent(event);
if (err == "inadequateSecurityError") {
// Remove the "Try again" button for HTTP/2 inadequate security as it