Bug 1359002 - stop checking the total time of processes against compartment data from all processes, r?Yoric draft
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Thu, 27 Apr 2017 14:42:05 +0100
changeset 572078 24c8d31f38adf2e7ca01352c8a4096ac4cc1d156
parent 571414 bfc7b187005cabbc828ed9f5b61daf139c3cfd90
child 626943 fa827d3dc61b90905b8cbffa060ae4b3724b0d2f
push id56988
push usergijskruitbosch@gmail.com
push dateWed, 03 May 2017 17:51:17 +0000
reviewersYoric
bugs1359002
milestone55.0a1
Bug 1359002 - stop checking the total time of processes against compartment data from all processes, r?Yoric MozReview-Commit-ID: BghONnEALsI
toolkit/components/perfmonitoring/tests/browser/browser_compartments.js
--- a/toolkit/components/perfmonitoring/tests/browser/browser_compartments.js
+++ b/toolkit/components/perfmonitoring/tests/browser/browser_compartments.js
@@ -153,27 +153,16 @@ function monotinicity_tester(source, tes
     SilentAssert.equal(snapshot.processData.isSystem, true, "Should be system");
     SilentAssert.equal(snapshot.processData.name, "<process>", "Should have '<process>' name");
     SilentAssert.equal(snapshot.processData.processId, pid, "Process id should match");
     previous.procesData = snapshot.processData;
 
     // Sanity check on components data.
     let map = new Map();
     for (let item of snapshot.componentsData) {
-      for (let [probe, k] of [
-        ["jank", "totalUserTime"],
-        ["jank", "totalSystemTime"],
-        ["cpow", "totalCPOWTime"]
-      ]) {
-        // Note that we cannot expect components data to be always smaller
-        // than process data, as `getrusage` & co are not monotonic.
-        SilentAssert.leq(item[probe][k], 6 * snapshot.processData[probe][k],
-          `Sanity check (${name}): ${k} of component is not impossibly larger than that of process`);
-      }
-
       let isCorrectPid = (item.processId == pid && !item.isChildProcess)
         || (item.processId != pid && item.isChildProcess);
       SilentAssert.ok(isCorrectPid, `Pid check (${name}): the item comes from the right process`);
 
       let key = item.groupId;
       if (map.has(key)) {
         let old = map.get(key);
         Assert.ok(false, `Component ${key} has already been seen. Latest: ${item.name}, previous: ${old.name}`);