Bug 1361270 - Avoid exception when searching in the Console panel; r=nchevobbe
MozReview-Commit-ID: FGF3gzI4hjG
--- a/devtools/client/webconsole/new-console-output/selectors/messages.js
+++ b/devtools/client/webconsole/new-console-output/selectors/messages.js
@@ -123,30 +123,30 @@ function matchSearchFilters(message, fil
functionName: frame.functionName ||
l10n.getStr("stacktrace.anonymousFunction"),
filename: frame.filename,
lineNumber: frame.lineNumber,
columnNumber: frame.columnNumber
}))
)
// Look for a match in messageText.
- || (message.messageText !== null
- && message.messageText.toLocaleLowerCase().includes(text.toLocaleLowerCase()))
+ || (message.messageText &&
+ message.messageText.toLocaleLowerCase().includes(text.toLocaleLowerCase()))
// Look for a match in parameters. Currently only checks value grips.
- || (message.parameters !== null
- && message.parameters.join("").toLocaleLowerCase()
- .includes(text.toLocaleLowerCase()))
+ || (message.parameters &&
+ message.parameters.join("").toLocaleLowerCase()
+ .includes(text.toLocaleLowerCase()))
// Look for a match in notes.
|| (Array.isArray(message.notes) && message.notes.some(note =>
// Look for a match in location.
isTextInFrame(text, note.frame)
// Look for a match in messageBody.
- || (note.messageBody !== null
- && note.messageBody.toLocaleLowerCase()
- .includes(text.toLocaleLowerCase()))
+ || (note.messageBody &&
+ note.messageBody.toLocaleLowerCase()
+ .includes(text.toLocaleLowerCase()))
))
);
}
/**
* Returns true if given text is included in provided stack frame.
*/
function isTextInFrame(text, frame) {