Bug 1361206: warn about non-matching RTP header extension IDs. r?bwc draft
authorNils Ohlmeier [:drno] <drno@ohlmeier.org>
Mon, 01 May 2017 21:02:53 -0700
changeset 575888 146e0aac6a3b4018a8d4be19cde983fe3ae3f3c7
parent 571131 2e7c10a9b86e30691f67855f6c8f98d984508d7c
child 628030 1af4a2bd5671878c07862b4e14456169c4e0e43a
push id58182
push userdrno@ohlmeier.org
push dateWed, 10 May 2017 22:24:04 +0000
reviewersbwc
bugs1361206
milestone55.0a1
Bug 1361206: warn about non-matching RTP header extension IDs. r?bwc MozReview-Commit-ID: DLG5ICBydAK
media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp
--- a/media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp
+++ b/media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp
@@ -2080,20 +2080,24 @@ JsepSessionImpl::ValidateAnswer(const Sd
                              "attribute at level " << i << " ("
                              << ansExt.extensionname << "). Offer had "
                              << offExt.direction << ", answer had "
                              << ansExt.direction << ".");
               // return NS_ERROR_INVALID_ARG;
             }
 
             if (offExt.entry < 4096 && (offExt.entry != ansExt.entry)) {
-              JSEP_SET_ERROR("Answer changed id for extmap attribute at level "
-                             << i << " (" << offExt.extensionname << ") from "
-                             << offExt.entry << " to " << ansExt.entry << ".");
-              return NS_ERROR_INVALID_ARG;
+              // FIXME we do not return an error here, because Cisco Spark
+              // actually does respond with different extension ID's then we
+              // offer. See bug 1361206 for details.
+              MOZ_MTLOG(ML_WARNING, "Answer changed id for extmap attribute at"
+                        " level " << i << " (" << offExt.extensionname << ") "
+                        "from " << offExt.entry << " to "
+                        << ansExt.entry << ".");
+              // return NS_ERROR_INVALID_ARG;
             }
 
             if (ansExt.entry >= 4096) {
               JSEP_SET_ERROR("Answer used an invalid id (" << ansExt.entry
                              << ") for extmap attribute at level " << i
                              << " (" << ansExt.extensionname << ").");
               return NS_ERROR_INVALID_ARG;
             }