Bug 1338521: delete send/recv video stream when destroying. r?jesup draft
authorNils Ohlmeier [:drno] <drno@ohlmeier.org>
Mon, 01 May 2017 12:55:59 -0700
changeset 570976 b466bd06fb4711538cdbe344f93afabb005e0015
parent 570496 8bbf0907b23a0f901697a6c17781e19dffc04657
child 626631 2f396245d67e10f28d024540e43cd909b51caaee
push id56643
push userdrno@ohlmeier.org
push dateMon, 01 May 2017 19:59:48 +0000
reviewersjesup
bugs1338521
milestone55.0a1
Bug 1338521: delete send/recv video stream when destroying. r?jesup MozReview-Commit-ID: 6wcOmyUWOEg
media/webrtc/signaling/src/media-conduit/VideoConduit.cpp
--- a/media/webrtc/signaling/src/media-conduit/VideoConduit.cpp
+++ b/media/webrtc/signaling/src/media-conduit/VideoConduit.cpp
@@ -339,16 +339,17 @@ WebrtcVideoConduit::DeleteSendStream()
   mCodecMutex.AssertCurrentThreadOwns();
   if (mSendStream) {
 
     if (mLoadManager && mSendStream->LoadStateObserver()) {
       mLoadManager->RemoveObserver(mSendStream->LoadStateObserver());
     }
 
     mCall->Call()->DestroyVideoSendStream(mSendStream);
+    delete mSendStream;
     mSendStream = nullptr;
     mEncoder = nullptr;
   }
 }
 
 MediaConduitErrorCode
 WebrtcVideoConduit::CreateSendStream()
 {
@@ -405,16 +406,17 @@ PayloadNameToDecoderType(const std::stri
 }
 
 void
 WebrtcVideoConduit::DeleteRecvStream()
 {
   mCodecMutex.AssertCurrentThreadOwns();
   if (mRecvStream) {
     mCall->Call()->DestroyVideoReceiveStream(mRecvStream);
+    delete mRecvStream;
     mRecvStream = nullptr;
     mDecoders.clear();
   }
 }
 
 MediaConduitErrorCode
 WebrtcVideoConduit::CreateRecvStream()
 {