Bug 1360429 - Part 1. inline arm assember for YCBCR should be on arm only. r?sotaro draft
authorMakoto Kato <m_kato@ga2.so-net.ne.jp>
Fri, 28 Apr 2017 13:22:07 +0900
changeset 569941 49d8ae4a8bd3a6ea3170c110e01edcfe5aefb906
parent 569701 2cca333f546f38860f84940d4c72d7470a3410f4
child 569942 692167e4cdacc58711c59c0a0462b57b50249c77
child 576785 ec83bdb7a10c9deff600d45512a53cac2ed678ea
push id56332
push userm_kato@ga2.so-net.ne.jp
push dateFri, 28 Apr 2017 04:32:42 +0000
reviewerssotaro
bugs1360429
milestone55.0a1
Bug 1360429 - Part 1. inline arm assember for YCBCR should be on arm only. r?sotaro ycvcr_to_rgb565 uses inline assember for arm neon. Since it is different for aarch64's assembler, we should define HAVE_YCBCR_TO_RGB565 on arm32 only. MozReview-Commit-ID: 4c2n1luvVvC
gfx/ycbcr/ycbcr_to_rgb565.h
--- a/gfx/ycbcr/ycbcr_to_rgb565.h
+++ b/gfx/ycbcr/ycbcr_to_rgb565.h
@@ -2,17 +2,17 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #ifndef MEDIA_BASE_YCBCR_TO_RGB565_H_
 #define MEDIA_BASE_YCBCR_TO_RGB565_H_
 #include "yuv_convert.h"
 #include "mozilla/arm.h"
 
 // It's currently only worth including this if we have NEON support.
-#ifdef MOZILLA_MAY_SUPPORT_NEON
+#if defined(__arm__) && defined(MOZILLA_MAY_SUPPORT_NEON)
 #define HAVE_YCBCR_TO_RGB565 1
 #endif
 
 namespace mozilla {
 
 namespace gfx {
 
 #ifdef HAVE_YCBCR_TO_RGB565