Bug 1360137 - Part 1. Use LowerCaseEqualsLiteral instead of ToLowerCase. r?masayuki draft
authorMakoto Kato <m_kato@ga2.so-net.ne.jp>
Thu, 27 Apr 2017 17:40:19 +0900
changeset 569279 26b6039441fe31dd0930f0a63bd99a5787c990f7
parent 569138 0b77ed3f26c5335503bc16e85b8c067382e7bb1e
child 569280 a285938311b4d75a3caada99a56da13c5a2ae45f
push id56124
push userm_kato@ga2.so-net.ne.jp
push dateThu, 27 Apr 2017 08:50:23 +0000
reviewersmasayuki
bugs1360137
milestone55.0a1
Bug 1360137 - Part 1. Use LowerCaseEqualsLiteral instead of ToLowerCase. r?masayuki From profiling TextEditor::OutputToString, most of WillOutputText is ToLowerCase. So, we should use LowerCaseEqualsLiteral instead. It can reduce string copy. MozReview-Commit-ID: LwqZtxIJTbW
editor/libeditor/TextEditRules.cpp
--- a/editor/libeditor/TextEditRules.cpp
+++ b/editor/libeditor/TextEditRules.cpp
@@ -1061,19 +1061,17 @@ TextEditRules::WillOutputText(Selection*
   if (!aOutString || !aOutputFormat || !aCancel || !aHandled) {
     return NS_ERROR_NULL_POINTER;
   }
 
   // initialize out param
   *aCancel = false;
   *aHandled = false;
 
-  nsAutoString outputFormat(*aOutputFormat);
-  ToLowerCase(outputFormat);
-  if (outputFormat.EqualsLiteral("text/plain")) {
+  if (aOutputFormat->LowerCaseEqualsLiteral("text/plain")) {
     // Only use these rules for plain text output.
     if (IsPasswordEditor()) {
       *aOutString = mPasswordText;
       *aHandled = true;
     } else if (mBogusNode) {
       // This means there's no content, so output null string.
       aOutString->Truncate();
       *aHandled = true;