Bug 1359852 - Use REPORT_BUILD for .xpt files; r?chmanchester draft
authorMike Shal <mshal@mozilla.com>
Tue, 18 Apr 2017 09:27:36 -0400
changeset 568789 ed8814727fc1eef877d835da13b783b3d9ac27f1
parent 567163 62b649c6b314f756f21cb95f2b0d491e2664e944
child 626026 dee6092bc58e1b71218679d534529709a9523851
push id55977
push userbmo:mshal@mozilla.com
push dateWed, 26 Apr 2017 15:27:20 +0000
reviewerschmanchester
bugs1359852
milestone55.0a1
Bug 1359852 - Use REPORT_BUILD for .xpt files; r?chmanchester By using $(REPORT_BUILD) instead of just echoing the filename, there is no change during a regular build without REBUILD_CHECK, but specifying REBUILD_CHECK in the environment will show which files triggered an .xpt to rebuild. This is helpful in debugging why these files may be built unnecessarily. MozReview-Commit-ID: GGNaKAl02Ea
config/makefiles/xpidl/Makefile.in
--- a/config/makefiles/xpidl/Makefile.in
+++ b/config/makefiles/xpidl/Makefile.in
@@ -28,17 +28,17 @@ idl_deps_dir := .deps
 
 dist_idl_dir := $(DIST)/idl
 dist_include_dir := $(DIST)/include
 process_py := $(topsrcdir)/python/mozbuild/mozbuild/action/xpidl-process.py
 
 # TODO we should use py_action, but that would require extra directories to be
 # in the virtualenv.
 %.xpt:
-	@echo "$(@F)"
+	$(REPORT_BUILD)
 	$(PYTHON_PATH) $(PLY_INCLUDE) -I$(topsrcdir)/xpcom/idl-parser -I$(DEPTH)/xpcom/idl-parser/xpidl \
 		$(process_py) --cache-dir $(DEPTH)/xpcom/idl-parser/xpidl --depsdir $(idl_deps_dir) \
 		$(dist_idl_dir) $(dist_include_dir) $(@D) $(libxul_sdk_includes) \
 		$(basename $(notdir $@)) $($(basename $(notdir $@))_deps)
 # When some IDL is added or removed, if the actual IDL file was already, or
 # still is, in the tree, simple dependencies can't detect that the XPT needs
 # to be rebuilt.
 # Add the current value of $($(xpidl_module)_deps) in the depend file, such that