Bug 1356415 - remove findCssSelector wrapper in devtools/shared/inspector/css-logic
MozReview-Commit-ID: C5fO62PCWjd
--- a/devtools/server/actors/inspector.js
+++ b/devtools/server/actors/inspector.js
@@ -151,18 +151,19 @@ loader.lazyGetter(this, "DOMParser", fun
.createInstance(Ci.nsIDOMParser);
});
loader.lazyGetter(this, "eventListenerService", function () {
return Cc["@mozilla.org/eventlistenerservice;1"]
.getService(Ci.nsIEventListenerService);
});
+loader.lazyImporter(this, "findCssSelector", "resource://gre/modules/css-selector.js");
+
loader.lazyRequireGetter(this, "CssLogic", "devtools/server/css-logic", true);
-loader.lazyRequireGetter(this, "findCssSelector", "devtools/shared/inspector/css-logic", true);
loader.lazyRequireGetter(this, "getCssPath", "devtools/shared/inspector/css-logic", true);
/**
* We only send nodeValue up to a certain size by default. This stuff
* controls that size.
*/
exports.DEFAULT_VALUE_SUMMARY_LENGTH = 50;
var gValueSummaryLength = exports.DEFAULT_VALUE_SUMMARY_LENGTH;
--- a/devtools/server/actors/script.js
+++ b/devtools/server/actors/script.js
@@ -22,18 +22,20 @@ const { threadSpec } = require("devtools
const { defer, resolve, reject, all } = promise;
loader.lazyGetter(this, "Debugger", () => {
let Debugger = require("Debugger");
hackDebugger(Debugger);
return Debugger;
});
+
+loader.lazyImporter(this, "findCssSelector", "resource://gre/modules/css-selector.js");
+
loader.lazyRequireGetter(this, "CssLogic", "devtools/server/css-logic", true);
-loader.lazyRequireGetter(this, "findCssSelector", "devtools/shared/inspector/css-logic", true);
loader.lazyRequireGetter(this, "events", "sdk/event/core");
loader.lazyRequireGetter(this, "mapURIToAddonID", "devtools/server/actors/utils/map-uri-to-addon-id");
loader.lazyRequireGetter(this, "BreakpointActor", "devtools/server/actors/breakpoint", true);
loader.lazyRequireGetter(this, "setBreakpointAtEntryPoints", "devtools/server/actors/breakpoint", true);
loader.lazyRequireGetter(this, "getSourceURL", "devtools/server/actors/source", true);
loader.lazyRequireGetter(this, "EnvironmentActor", "devtools/server/actors/environment", true);
loader.lazyRequireGetter(this, "FrameActor", "devtools/server/actors/frame", true);
--- a/devtools/shared/inspector/css-logic.js
+++ b/devtools/shared/inspector/css-logic.js
@@ -40,18 +40,16 @@ const { getTabPrefs } = require("devtool
* helps them understand:
* - why their expectations may not have been fulfilled
* - how browsers process CSS
* @constructor
*/
const Services = require("Services");
-loader.lazyImporter(this, "findCssSelector", "resource://gre/modules/css-selector.js");
-
const CSSLexer = require("devtools/shared/css/lexer");
const {LocalizationHelper} = require("devtools/shared/l10n");
const styleInspectorL10N =
new LocalizationHelper("devtools/shared/locales/styleinspector.properties");
/**
* Special values for filter, in addition to an href these values can be used
*/
@@ -343,23 +341,16 @@ function prettifyCSS(text, ruleCount) {
}
return result;
}
exports.prettifyCSS = prettifyCSS;
/**
- * Find a unique CSS selector for a given element
- * @returns a string such that ele.ownerDocument.querySelector(reply) === ele
- * and ele.ownerDocument.querySelectorAll(reply).length === 1
- */
-exports.findCssSelector = findCssSelector;
-
-/**
* Get the full CSS path for a given element.
* @returns a string that can be used as a CSS selector for the element. It might not
* match the element uniquely. It does however, represent the full path from the root
* node to the element.
*/
function getCssPath(ele) {
ele = getRootBindingParent(ele);
const document = ele.ownerDocument;