Bug 1355648 - Part 3: Set position and orientation IsValid properties for GamepadPose tests; r?kip draft
authorDaosheng Mu <daoshengmu@gmail.com>
Wed, 26 Apr 2017 13:17:25 +0800
changeset 568423 2d2340365d600f6a49240138ed79df07db7b7c67
parent 568422 9eeb4ec9d265f232e7741f9b63018a2a43e54b92
child 625922 e276fd51ad8d1877f01ca33839392e04a89fc851
push id55867
push userbmo:dmu@mozilla.com
push dateWed, 26 Apr 2017 06:11:42 +0000
reviewerskip
bugs1355648
milestone55.0a1
Bug 1355648 - Part 3: Set position and orientation IsValid properties for GamepadPose tests; r?kip MozReview-Commit-ID: 29sjo3yhg98
dom/gamepad/GamepadServiceTest.cpp
dom/vr/VRServiceTest.cpp
--- a/dom/gamepad/GamepadServiceTest.cpp
+++ b/dom/gamepad/GamepadServiceTest.cpp
@@ -255,24 +255,26 @@ GamepadServiceTest::NewPoseMove(uint32_t
   if (!aOrient.IsNull()) {
     const Float32Array& value = aOrient.Value();
     value.ComputeLengthAndData();
     MOZ_ASSERT(value.Length() == 4);
     poseState.orientation[0] = value.Data()[0];
     poseState.orientation[1] = value.Data()[1];
     poseState.orientation[2] = value.Data()[2];
     poseState.orientation[3] = value.Data()[3];
+    poseState.isOrientationValid = true;
   }
   if (!aPos.IsNull()) {
     const Float32Array& value = aPos.Value();
     value.ComputeLengthAndData();
     MOZ_ASSERT(value.Length() == 3);
     poseState.position[0] = value.Data()[0];
     poseState.position[1] = value.Data()[1];
     poseState.position[2] = value.Data()[2];
+    poseState.isPositionValid = true;
   }
   if (!aAngVelocity.IsNull()) {
     const Float32Array& value = aAngVelocity.Value();
     value.ComputeLengthAndData();
     MOZ_ASSERT(value.Length() == 3);
     poseState.angularVelocity[0] = value.Data()[0];
     poseState.angularVelocity[1] = value.Data()[1];
     poseState.angularVelocity[2] = value.Data()[2];
--- a/dom/vr/VRServiceTest.cpp
+++ b/dom/vr/VRServiceTest.cpp
@@ -207,24 +207,26 @@ VRMockController::NewPoseMove(const Null
   if (!aOrientation.IsNull()) {
     const Float32Array& value = aOrientation.Value();
     value.ComputeLengthAndData();
     MOZ_ASSERT(value.Length() == 4);
     poseState.orientation[0] = value.Data()[0];
     poseState.orientation[1] = value.Data()[1];
     poseState.orientation[2] = value.Data()[2];
     poseState.orientation[3] = value.Data()[3];
+    poseState.isOrientationValid = true;
   }
   if (!aPosition.IsNull()) {
     const Float32Array& value = aPosition.Value();
     value.ComputeLengthAndData();
     MOZ_ASSERT(value.Length() == 3);
     poseState.position[0] = value.Data()[0];
     poseState.position[1] = value.Data()[1];
     poseState.position[2] = value.Data()[2];
+    poseState.isPositionValid = true;
   }
   if (!aAngularVelocity.IsNull()) {
     const Float32Array& value = aAngularVelocity.Value();
     value.ComputeLengthAndData();
     MOZ_ASSERT(value.Length() == 3);
     poseState.angularVelocity[0] = value.Data()[0];
     poseState.angularVelocity[1] = value.Data()[1];
     poseState.angularVelocity[2] = value.Data()[2];