Bug 1355348 - Drop extra eRestyle_StyleAttribute hint from Element::SetSMILOverrideStyleDeclaration; r?dbaron draft
authorBrian Birtles <birtles@gmail.com>
Wed, 26 Apr 2017 12:59:31 +0900
changeset 568394 a20adfbc8ea50f59bf420a99d494d40fa709bcee
parent 568387 98a059786739461a4a525a18fd0eb1f69ddaf7f1
child 568395 1ae64307252e077a0e39720781b85d27a0bc9cdb
push id55859
push userbbirtles@mozilla.com
push dateWed, 26 Apr 2017 04:45:43 +0000
reviewersdbaron
bugs1355348, 1133439
milestone55.0a1
Bug 1355348 - Drop extra eRestyle_StyleAttribute hint from Element::SetSMILOverrideStyleDeclaration; r?dbaron This was originally added in bug 1133439 but it's not clear that it is needed. It may be that we thought that new SMIL animations should trigger transitions but that's not the case. We want to remove this as part of this bug since Servo_NoteExplicitHints is currently not capable of handling animation restyle hints and non-animation restyle hints at the same time. MozReview-Commit-ID: 5VJTMOLdLPU
dom/base/Element.cpp
--- a/dom/base/Element.cpp
+++ b/dom/base/Element.cpp
@@ -1949,22 +1949,17 @@ Element::SetSMILOverrideStyleDeclaration
   if (aNotify) {
     nsIDocument* doc = GetComposedDoc();
     // Only need to request a restyle if we're in a document.  (We might not
     // be in a document, if we're clearing animation effects on a target node
     // that's been detached since the previous animation sample.)
     if (doc) {
       nsCOMPtr<nsIPresShell> shell = doc->GetShell();
       if (shell) {
-        // Pass both eRestyle_StyleAttribute and
-        // eRestyle_StyleAttribute_Animations since we don't know if
-        // this style represents only the ticking of an existing
-        // animation or whether it's a new or changed animation.
-        shell->RestyleForAnimation(this, eRestyle_StyleAttribute |
-                                         eRestyle_StyleAttribute_Animations);
+        shell->RestyleForAnimation(this, eRestyle_StyleAttribute_Animations);
       }
     }
   }
 
   return NS_OK;
 }
 
 bool