Bug 1354518 - De-duplicate already recommended ESLint rules in toolkit/components/narrate/.eslintrc.js. r?standard8 draft
authorHemant Singh Patwal <hemantsingh1612@gmail.com>
Tue, 25 Apr 2017 19:55:58 +0530
changeset 567777 0f741632a4ee15a14c17b66b980e120cbf7fbf30
parent 562868 1a1069b27f40edbfbcf1aa81a5e7dfb39845a5fe
child 625761 b70c00a1754e33cf3439c124ad82d8f32f700081
push id55693
push userbmo:hemantsingh1612@gmail.com
push dateTue, 25 Apr 2017 14:25:57 +0000
reviewersstandard8
bugs1354518
milestone55.0a1
Bug 1354518 - De-duplicate already recommended ESLint rules in toolkit/components/narrate/.eslintrc.js. r?standard8 MozReview-Commit-ID: 2QClhuKkLVU
toolkit/components/narrate/.eslintrc.js
--- a/toolkit/components/narrate/.eslintrc.js
+++ b/toolkit/components/narrate/.eslintrc.js
@@ -1,94 +1,51 @@
 "use strict";
 
 module.exports = {
-  "extends": [
-    "../../.eslintrc.js"
-  ],
-
   "globals": {
-    "Components": true,
-    "dump": true,
     "Iterator": true
   },
 
-  "env": { "browser": true },
-
   "rules": {
-    // Mozilla stuff
     "mozilla/no-aArgs": "warn",
     "mozilla/reject-importGlobalProperties": "warn",
     "mozilla/var-only-at-top-level": "warn",
-
     "block-scoped-var": "error",
-    "brace-style": ["warn", "1tbs", {"allowSingleLine": false}],
     "camelcase": "warn",
     "comma-dangle": "off",
-    "comma-spacing": ["warn", {"before": false, "after": true}],
     "comma-style": ["warn", "last"],
     "complexity": ["error", {"max": 20}],
-    "consistent-return": "error",
     "curly": "error",
     "dot-location": ["warn", "property"],
     "dot-notation": "error",
-    "eol-last": "error",
     "generator-star-spacing": ["warn", "after"],
     "indent": ["warn", 2, {"SwitchCase": 1}],
-    "key-spacing": ["warn", {"beforeColon": false, "afterColon": true}],
-    "keyword-spacing": "warn",
     "max-len": ["warn", 80, 2, {"ignoreUrls": true}],
     "max-nested-callbacks": ["error", 3],
     "new-cap": ["error", {"capIsNew": false}],
     "new-parens": "error",
     "no-array-constructor": "error",
-    "no-cond-assign": "error",
     "no-control-regex": "error",
-    "no-debugger": "error",
-    "no-delete-var": "error",
-    "no-dupe-args": "error",
-    "no-dupe-keys": "error",
-    "no-duplicate-case": "error",
-    "no-else-return": "error",
     "no-eval": "error",
     "no-extend-native": "error",
-    "no-extra-bind": "error",
-    "no-extra-boolean-cast": "error",
-    "no-extra-semi": "warn",
     "no-fallthrough": "error",
     "no-inline-comments": "warn",
-    "no-lonely-if": "error",
     "no-mixed-spaces-and-tabs": "error",
     "no-multi-spaces": "warn",
     "no-multi-str": "warn",
     "no-multiple-empty-lines": ["warn", {"max": 1}],
-    "no-native-reassign": "error",
-    "no-nested-ternary": "error",
-    "no-redeclare": "error",
     "no-return-assign": "error",
-    "no-self-compare": "error",
     "no-sequences": "error",
     "no-shadow": "warn",
-    "no-shadow-restricted-names": "error",
     "no-spaced-func": "warn",
     "no-throw-literal": "error",
-    "no-trailing-spaces": "error",
-    "no-undef": "error",
     "no-unneeded-ternary": "error",
-    "no-unreachable": "error",
     "no-unused-vars": "error",
-    "no-with": "error",
     "padded-blocks": ["warn", "never"],
     "quotes": ["warn", "double", "avoid-escape"],
     "semi": ["warn", "always"],
     "semi-spacing": ["warn", {"before": false, "after": true}],
-    "space-before-blocks": ["warn", "always"],
-    "space-before-function-paren": ["warn", "never"],
     "space-in-parens": ["warn", "never"],
-    "space-infix-ops": ["warn", {"int32Hint": true}],
-    "space-unary-ops": ["warn", { "words": true, "nonwords": false }],
-    "spaced-comment": ["warn", "always"],
     "strict": ["error", "global"],
-    "use-isnan": "error",
-    "valid-typeof": "error",
     "yoda": "error"
   }
 };