Bug 1352108 - Add missing attributes to custom tab activity declaration. r?sebastian draft
authorJan Henning <jh+bugzilla@buttercookie.de>
Mon, 24 Apr 2017 21:05:39 +0200
changeset 567309 36c337ae3484115f3a9fb0acdd6b7235d8eb108d
parent 567307 ab05f05d26c4f2d2254b571f992cb698a6109c91
child 625599 5b23b156cb43e8aea3b482ac2dd843a4502492dc
push id55521
push usermozilla@buttercookie.de
push dateMon, 24 Apr 2017 19:08:16 +0000
reviewerssebastian
bugs1352108
milestone55.0a1
Bug 1352108 - Add missing attributes to custom tab activity declaration. r?sebastian Not handling the appropriate configuration changes means that e.g. each rotation destroys and recreates the CustomTabActivity, which'll introduce a slight delay until we eventually repaint the web content. As for the soft input mode, if we don't specify adjustResize, then the IME might actually simply overlap our window and obscure the end of content if the user has already scrolled down as far as possible. MozReview-Commit-ID: BzBmIoGbhca
mobile/android/base/AndroidManifest.xml.in
--- a/mobile/android/base/AndroidManifest.xml.in
+++ b/mobile/android/base/AndroidManifest.xml.in
@@ -307,18 +307,21 @@
                 <category android:name="android.intent.category.DEFAULT" />
                 <data android:mimeType="text/plain" />
             </intent-filter>
 
         </activity>
 
 #ifdef MOZ_ANDROID_CUSTOM_TABS
         <activity android:name="org.mozilla.gecko.customtabs.CustomTabsActivity"
-            android:theme="@style/GeckoCustomTabs" />
+                  android:configChanges="keyboard|keyboardHidden|mcc|mnc|orientation|screenSize|locale|layoutDirection|smallestScreenSize|screenLayout"
+                  android:windowSoftInputMode="stateUnspecified|adjustResize"
+                  android:theme="@style/GeckoCustomTabs" />
 #endif
+
         <activity android:name="org.mozilla.gecko.webapps.WebAppActivity"
             android:theme="@style/Theme.AppCompat.NoActionBar" />
 
         <!-- Declare a predefined number of WebApp<num> activities. These are
              used so that each web app can launch in its own activity. -->
 #define FRAGMENT WebAppManifestFragment.xml.frag.in
 #include WebAppFragmentRepeater.inc