Bug 1358968 - Part 1: Store in nsCSSAnonBoxList.h whether an anon box skips parent display-based style fixups. r=bz draft
authorCameron McCormack <cam@mcc.id.au>
Mon, 24 Apr 2017 16:17:28 +0800
changeset 570509 f3fcb4c5dac78a682cfc373bb699c8f41ae412cf
parent 570508 6df3dfa9bed3efd3650d594c71a40a8aa34bfa7f
child 570510 339fada8cf163e75eb6561353a8cc3cb007dc0bc
push id56510
push userbmo:cam@mcc.id.au
push dateSat, 29 Apr 2017 00:48:31 +0000
reviewersbz
bugs1358968
milestone55.0a1
Bug 1358968 - Part 1: Store in nsCSSAnonBoxList.h whether an anon box skips parent display-based style fixups. r=bz MozReview-Commit-ID: 3DlGa5sH4eX
layout/style/nsCSSAnonBoxList.h
layout/style/nsCSSAnonBoxes.cpp
layout/style/nsCSSAnonBoxes.h
--- a/layout/style/nsCSSAnonBoxList.h
+++ b/layout/style/nsCSSAnonBoxList.h
@@ -7,115 +7,122 @@
 
 /*
  * This file contains the list of nsIAtoms and their values for CSS
  * pseudo-element-ish things used internally for anonymous boxes.  It is
  * designed to be used as inline input to nsCSSAnonBoxes.cpp *only* through the
  * magic of C preprocessing.  All entries must be enclosed in the macros
  * CSS_ANON_BOX and CSS_NON_INHERITING_ANON_BOX which will have cruel and
  * unusual things done to it.  The entries should be kept in some sort of
- * logical order.  The first argument to
- * CSS_ANON_BOX/CSS_NON_INHERITING_ANON_BOX is the C++ identifier of the atom.
+ * logical order.
+ *
+ * The first argument to CSS_ANON_BOX/CSS_NON_INHERITING_ANON_BOX is the C++
+ * identifier of the atom.
+ *
  * The second argument is the string value of the atom.
  *
+ * The third argument to CSS_ANON_BOX is whether the anonymous box skips parent-
+ * based display fixups (such as blockification inside flex containers).  This
+ * is implicitly true for CSS_NON_INHERITING_ANON_BOX.
+ *
  * CSS_NON_INHERITING_ANON_BOX is used for anon boxes that never inherit style
  * from anything.  This means all their property values are the initial values
  * of those properties.
  */
 
 // OUTPUT_CLASS=nsCSSAnonBoxes
 // MACRO_NAME=CSS_ANON_BOX/CSS_NON_INHERITING_ANON_BOX
 
 #ifndef CSS_NON_INHERITING_ANON_BOX
 #  ifdef DEFINED_CSS_NON_INHERITING_ANON_BOX
 #    error "Recursive includes of nsCSSAnonBoxList.h?"
 #  endif /* DEFINED_CSS_NON_INHERITING_ANON_BOX */
-#  define CSS_NON_INHERITING_ANON_BOX CSS_ANON_BOX
+#  define CSS_NON_INHERITING_ANON_BOX(name_, value_) CSS_ANON_BOX(name_, value_, true)
 #  define DEFINED_CSS_NON_INHERITING_ANON_BOX
 #endif /* CSS_NON_INHERITING_ANON_BOX */
 
 // ::-moz-text, ::-moz-oof-placeholder, and ::-moz-first-letter-continuation are
 // non-elements which no rule will match.
-CSS_ANON_BOX(mozText, ":-moz-text")
+CSS_ANON_BOX(mozText, ":-moz-text", false)
 // placeholder frames for out of flows.  Note that :-moz-placeholder is used for
 // the pseudo-element that represents the placeholder text in <input
 // placeholder="foo">, so we need a different string here.
 CSS_NON_INHERITING_ANON_BOX(oofPlaceholder, ":-moz-oof-placeholder")
 // nsFirstLetterFrames for content outside the ::first-letter.
-CSS_ANON_BOX(firstLetterContinuation, ":-moz-first-letter-continuation")
+CSS_ANON_BOX(firstLetterContinuation, ":-moz-first-letter-continuation", false)
 
-CSS_ANON_BOX(mozBlockInsideInlineWrapper, ":-moz-block-inside-inline-wrapper")
-CSS_ANON_BOX(mozMathMLAnonymousBlock, ":-moz-mathml-anonymous-block")
-CSS_ANON_BOX(mozXULAnonymousBlock, ":-moz-xul-anonymous-block")
+CSS_ANON_BOX(mozBlockInsideInlineWrapper, ":-moz-block-inside-inline-wrapper", false)
+CSS_ANON_BOX(mozMathMLAnonymousBlock, ":-moz-mathml-anonymous-block", false)
+CSS_ANON_BOX(mozXULAnonymousBlock, ":-moz-xul-anonymous-block", false)
 
 // Framesets
 CSS_NON_INHERITING_ANON_BOX(horizontalFramesetBorder, ":-moz-hframeset-border")
 CSS_NON_INHERITING_ANON_BOX(verticalFramesetBorder, ":-moz-vframeset-border")
 
-CSS_ANON_BOX(mozLineFrame, ":-moz-line-frame")
+CSS_ANON_BOX(mozLineFrame, ":-moz-line-frame", false)
 
-CSS_ANON_BOX(buttonContent, ":-moz-button-content")
-CSS_ANON_BOX(cellContent, ":-moz-cell-content")
-CSS_ANON_BOX(dropDownList, ":-moz-dropdown-list")
-CSS_ANON_BOX(fieldsetContent, ":-moz-fieldset-content")
+CSS_ANON_BOX(buttonContent, ":-moz-button-content", false)
+CSS_ANON_BOX(cellContent, ":-moz-cell-content", false)
+CSS_ANON_BOX(dropDownList, ":-moz-dropdown-list", false)
+CSS_ANON_BOX(fieldsetContent, ":-moz-fieldset-content", false)
 CSS_NON_INHERITING_ANON_BOX(framesetBlank, ":-moz-frameset-blank")
-CSS_ANON_BOX(mozDisplayComboboxControlFrame, ":-moz-display-comboboxcontrol-frame")
-CSS_ANON_BOX(htmlCanvasContent, ":-moz-html-canvas-content")
+CSS_ANON_BOX(mozDisplayComboboxControlFrame, ":-moz-display-comboboxcontrol-frame", true)
+CSS_ANON_BOX(htmlCanvasContent, ":-moz-html-canvas-content", false)
 
-CSS_ANON_BOX(inlineTable, ":-moz-inline-table")
-CSS_ANON_BOX(table, ":-moz-table")
-CSS_ANON_BOX(tableCell, ":-moz-table-cell")
-CSS_ANON_BOX(tableColGroup, ":-moz-table-column-group")
-CSS_ANON_BOX(tableCol, ":-moz-table-column")
-CSS_ANON_BOX(tableWrapper, ":-moz-table-wrapper")
-CSS_ANON_BOX(tableRowGroup, ":-moz-table-row-group")
-CSS_ANON_BOX(tableRow, ":-moz-table-row")
+CSS_ANON_BOX(inlineTable, ":-moz-inline-table", false)
+CSS_ANON_BOX(table, ":-moz-table", false)
+CSS_ANON_BOX(tableCell, ":-moz-table-cell", false)
+CSS_ANON_BOX(tableColGroup, ":-moz-table-column-group", false)
+CSS_ANON_BOX(tableCol, ":-moz-table-column", false)
+CSS_ANON_BOX(tableWrapper, ":-moz-table-wrapper", false)
+CSS_ANON_BOX(tableRowGroup, ":-moz-table-row-group", false)
+CSS_ANON_BOX(tableRow, ":-moz-table-row", false)
 
-CSS_ANON_BOX(canvas, ":-moz-canvas")
+CSS_ANON_BOX(canvas, ":-moz-canvas", false)
 CSS_NON_INHERITING_ANON_BOX(pageBreak, ":-moz-pagebreak")
-CSS_ANON_BOX(page, ":-moz-page")
-CSS_ANON_BOX(pageContent, ":-moz-pagecontent")
-CSS_ANON_BOX(pageSequence, ":-moz-page-sequence")
-CSS_ANON_BOX(scrolledContent, ":-moz-scrolled-content")
-CSS_ANON_BOX(scrolledCanvas, ":-moz-scrolled-canvas")
-CSS_ANON_BOX(scrolledPageSequence, ":-moz-scrolled-page-sequence")
-CSS_ANON_BOX(columnContent, ":-moz-column-content")
-CSS_ANON_BOX(viewport, ":-moz-viewport")
-CSS_ANON_BOX(viewportScroll, ":-moz-viewport-scroll")
+CSS_ANON_BOX(page, ":-moz-page", false)
+CSS_ANON_BOX(pageContent, ":-moz-pagecontent", false)
+CSS_ANON_BOX(pageSequence, ":-moz-page-sequence", false)
+CSS_ANON_BOX(scrolledContent, ":-moz-scrolled-content", false)
+CSS_ANON_BOX(scrolledCanvas, ":-moz-scrolled-canvas", false)
+CSS_ANON_BOX(scrolledPageSequence, ":-moz-scrolled-page-sequence", false)
+CSS_ANON_BOX(columnContent, ":-moz-column-content", false)
+CSS_ANON_BOX(viewport, ":-moz-viewport", false)
+CSS_ANON_BOX(viewportScroll, ":-moz-viewport-scroll", false)
 
 // Inside a flex container, a contiguous run of text gets wrapped in
 // an anonymous block, which is then treated as a flex item.
-CSS_ANON_BOX(anonymousFlexItem, ":-moz-anonymous-flex-item")
+CSS_ANON_BOX(anonymousFlexItem, ":-moz-anonymous-flex-item", false)
 
 // Inside a grid container, a contiguous run of text gets wrapped in
 // an anonymous block, which is then treated as a grid item.
-CSS_ANON_BOX(anonymousGridItem, ":-moz-anonymous-grid-item")
+CSS_ANON_BOX(anonymousGridItem, ":-moz-anonymous-grid-item", false)
 
-CSS_ANON_BOX(ruby, ":-moz-ruby")
-CSS_ANON_BOX(rubyBase, ":-moz-ruby-base")
-CSS_ANON_BOX(rubyBaseContainer, ":-moz-ruby-base-container")
-CSS_ANON_BOX(rubyText, ":-moz-ruby-text")
-CSS_ANON_BOX(rubyTextContainer, ":-moz-ruby-text-container")
+CSS_ANON_BOX(ruby, ":-moz-ruby", false)
+CSS_ANON_BOX(rubyBase, ":-moz-ruby-base", false)
+CSS_ANON_BOX(rubyBaseContainer, ":-moz-ruby-base-container", false)
+CSS_ANON_BOX(rubyText, ":-moz-ruby-text", false)
+CSS_ANON_BOX(rubyTextContainer, ":-moz-ruby-text-container", false)
 
 #ifdef MOZ_XUL
-CSS_ANON_BOX(moztreecolumn, ":-moz-tree-column")
-CSS_ANON_BOX(moztreerow, ":-moz-tree-row")
-CSS_ANON_BOX(moztreeseparator, ":-moz-tree-separator")
-CSS_ANON_BOX(moztreecell, ":-moz-tree-cell")
-CSS_ANON_BOX(moztreeindentation, ":-moz-tree-indentation")
-CSS_ANON_BOX(moztreeline, ":-moz-tree-line")
-CSS_ANON_BOX(moztreetwisty, ":-moz-tree-twisty")
-CSS_ANON_BOX(moztreeimage, ":-moz-tree-image")
-CSS_ANON_BOX(moztreecelltext, ":-moz-tree-cell-text")
-CSS_ANON_BOX(moztreecheckbox, ":-moz-tree-checkbox")
-CSS_ANON_BOX(moztreeprogressmeter, ":-moz-tree-progressmeter")
-CSS_ANON_BOX(moztreedropfeedback, ":-moz-tree-drop-feedback")
+CSS_ANON_BOX(moztreecolumn, ":-moz-tree-column", false)
+CSS_ANON_BOX(moztreerow, ":-moz-tree-row", false)
+CSS_ANON_BOX(moztreeseparator, ":-moz-tree-separator", false)
+CSS_ANON_BOX(moztreecell, ":-moz-tree-cell", false)
+CSS_ANON_BOX(moztreeindentation, ":-moz-tree-indentation", false)
+CSS_ANON_BOX(moztreeline, ":-moz-tree-line", false)
+CSS_ANON_BOX(moztreetwisty, ":-moz-tree-twisty", false)
+CSS_ANON_BOX(moztreeimage, ":-moz-tree-image", false)
+CSS_ANON_BOX(moztreecelltext, ":-moz-tree-cell-text", false)
+CSS_ANON_BOX(moztreecheckbox, ":-moz-tree-checkbox", false)
+CSS_ANON_BOX(moztreeprogressmeter, ":-moz-tree-progressmeter", false)
+CSS_ANON_BOX(moztreedropfeedback, ":-moz-tree-drop-feedback", false)
 #endif
 
-CSS_ANON_BOX(mozSVGMarkerAnonChild, ":-moz-svg-marker-anon-child")
-CSS_ANON_BOX(mozSVGOuterSVGAnonChild, ":-moz-svg-outer-svg-anon-child")
-CSS_ANON_BOX(mozSVGForeignContent, ":-moz-svg-foreign-content")
-CSS_ANON_BOX(mozSVGText, ":-moz-svg-text")
+CSS_ANON_BOX(mozSVGMarkerAnonChild, ":-moz-svg-marker-anon-child", false)
+CSS_ANON_BOX(mozSVGOuterSVGAnonChild, ":-moz-svg-outer-svg-anon-child", false)
+CSS_ANON_BOX(mozSVGForeignContent, ":-moz-svg-foreign-content", false)
+CSS_ANON_BOX(mozSVGText, ":-moz-svg-text", false)
 
 #ifdef DEFINED_CSS_NON_INHERITING_ANON_BOX
 #  undef DEFINED_CSS_NON_INHERITING_ANON_BOX
 #  undef CSS_NON_INHERITING_ANON_BOX
 #endif /* DEFINED_CSS_NON_INHERITING_ANON_BOX */
--- a/layout/style/nsCSSAnonBoxes.cpp
+++ b/layout/style/nsCSSAnonBoxes.cpp
@@ -9,36 +9,36 @@
 
 #include "nsCSSAnonBoxes.h"
 #include "nsAtomListUtils.h"
 #include "nsStaticAtom.h"
 
 using namespace mozilla;
 
 // define storage for all atoms
-#define CSS_ANON_BOX(_name, _value) \
-  nsICSSAnonBoxPseudo* nsCSSAnonBoxes::_name;
+#define CSS_ANON_BOX(name_, value_, skips_fixup_) \
+  nsICSSAnonBoxPseudo* nsCSSAnonBoxes::name_;
 #include "nsCSSAnonBoxList.h"
 #undef CSS_ANON_BOX
 
-#define CSS_ANON_BOX(name_, value_) \
+#define CSS_ANON_BOX(name_, value_, skips_fixup_) \
   NS_STATIC_ATOM_BUFFER(name_##_buffer, value_)
 #include "nsCSSAnonBoxList.h"
 #undef CSS_ANON_BOX
 
 static const nsStaticAtom CSSAnonBoxes_info[] = {
   // Put the non-inheriting anon boxes first, so we can index into them easily.
-#define CSS_ANON_BOX(name_, value_) /* nothing */
+#define CSS_ANON_BOX(name_, value_, skips_fixup_) /* nothing */
 #define CSS_NON_INHERITING_ANON_BOX(name_, value_) \
   NS_STATIC_ATOM(name_##_buffer, (nsIAtom**)&nsCSSAnonBoxes::name_),
 #include "nsCSSAnonBoxList.h"
 #undef CSS_NON_INHERITING_ANON_BOX
 #undef CSS_ANON_BOX
 
-#define CSS_ANON_BOX(name_, value_)                                   \
+#define CSS_ANON_BOX(name_, value_, skips_fixup_) \
   NS_STATIC_ATOM(name_##_buffer, (nsIAtom**)&nsCSSAnonBoxes::name_),
 #define CSS_NON_INHERITING_ANON_BOX(name_, value_) /* nothing */
 #include "nsCSSAnonBoxList.h"
 #undef CSS_NON_INHERITING_ANON_BOX
 #undef CSS_ANON_BOX
 };
 
 void nsCSSAnonBoxes::AddRefAtoms()
--- a/layout/style/nsCSSAnonBoxes.h
+++ b/layout/style/nsCSSAnonBoxes.h
@@ -24,46 +24,64 @@ public:
   static bool IsTreePseudoElement(nsIAtom* aPseudo);
 #endif
   static bool IsNonElement(nsIAtom* aPseudo)
   {
     return aPseudo == mozText || aPseudo == oofPlaceholder ||
            aPseudo == firstLetterContinuation;
   }
 
-#define CSS_ANON_BOX(_name, _value) static nsICSSAnonBoxPseudo* _name;
+#define CSS_ANON_BOX(_name, _value, _skips_fixup) static nsICSSAnonBoxPseudo* _name;
 #include "nsCSSAnonBoxList.h"
 #undef CSS_ANON_BOX
 
   typedef uint8_t NonInheritingBase;
   enum class NonInheriting : NonInheritingBase {
-#define CSS_ANON_BOX(_name, _value) /* nothing */
+#define CSS_ANON_BOX(_name, _value, _skips_fixup) /* nothing */
 #define CSS_NON_INHERITING_ANON_BOX(_name, _value) _name,
 #include "nsCSSAnonBoxList.h"
 #undef CSS_NON_INHERITING_ANON_BOX
 #undef CSS_ANON_BOX
     _Count
   };
 
   // Be careful using this: if we have a lot of non-inheriting anon box types it
   // might not be very fast.  We may want to think of ways to handle that
   // (e.g. by moving to an enum instead of an atom, like we did for
   // pseudo-elements, or by adding a new value of the pseudo-element enum for
   // non-inheriting anon boxes or something).
   static bool IsNonInheritingAnonBox(nsIAtom* aPseudo)
   {
     return
-#define CSS_ANON_BOX(_name, _value) /* nothing */
+#define CSS_ANON_BOX(_name, _value, _skips_fixup) /* nothing */
 #define CSS_NON_INHERITING_ANON_BOX(_name, _value) _name == aPseudo ||
 #include "nsCSSAnonBoxList.h"
 #undef CSS_NON_INHERITING_ANON_BOX
 #undef CSS_ANON_BOX
       false;
   }
 
+  // Returns whether the given anonymous box skips parent display-based style
+  // fixups.  Must only be called with an inheriting anonymous box.  (All
+  // non-inheriting anonymous boxes skip this fixup, since it doesn't make
+  // sense to perform the fixup with no inherited styles.)
+  static bool AnonBoxSkipsParentDisplayBasedStyleFixup(nsIAtom* aPseudo)
+  {
+    MOZ_ASSERT(!IsNonInheritingAnonBox(aPseudo),
+               "only call this for inheriting anonymous boxes");
+    return
+#define CSS_ANON_BOX(name_, value_, skips_fixup_) \
+      (skips_fixup_ && name_ == aPseudo) ||
+#define CSS_NON_INHERITING_ANON_BOX(_name, _value) /* nothing */
+#include "nsCSSAnonBoxList.h"
+#undef CSS_NON_INHERITING_ANON_BOX
+#undef CSS_ANON_BOX
+      false;
+  }
+
   // Get the NonInheriting type for a given pseudo tag.  The pseudo tag must
   // test true for IsNonInheritingAnonBox.
   static NonInheriting NonInheritingTypeForPseudoTag(nsIAtom* aPseudo);
 
   // Get the atom for a given non-inheriting anon box type.  aBoxType must be <
   // NonInheriting::_Count.
   static nsIAtom* GetNonInheritingPseudoAtom(NonInheriting aBoxType);
 };