Bug 1355882 - Remove Addon Histograms from about:telemetry draft
authorflyingrub <flyinggrub@gmail.com>
Mon, 26 Jun 2017 14:39:32 +0200
changeset 600406 8ff63ff0c1094388a0825cd65f38d93159bd3861
parent 600405 af9a8cebd43fb23822be25c5d4d065d5e9e195b8
child 634974 15329c4801b5fc8de74fd9b0707432bc89816205
push id65741
push userbmo:flyinggrub@gmail.com
push dateMon, 26 Jun 2017 12:40:14 +0000
bugs1355882
milestone56.0a1
Bug 1355882 - Remove Addon Histograms from about:telemetry Removed all code related to Addon Histograms MozReview-Commit-ID: 878X06QizFX
toolkit/content/aboutTelemetry.css
toolkit/content/aboutTelemetry.js
toolkit/content/aboutTelemetry.xhtml
toolkit/locales/en-US/chrome/global/aboutTelemetry.dtd
--- a/toolkit/content/aboutTelemetry.css
+++ b/toolkit/content/aboutTelemetry.css
@@ -168,17 +168,17 @@ body {
 }
 
 .stack-title {
   font-size: medium;
   font-weight: bold;
   text-decoration: underline;
 }
 
-#histograms, #addon-histograms, #thread-hang-stats>div {
+#histograms, #thread-hang-stats>div {
   overflow: hidden;
 }
 
 .histogram {
   float: left;
   border: 1px solid gray;
   white-space: nowrap;
   padding: 10px;
--- a/toolkit/content/aboutTelemetry.js
+++ b/toolkit/content/aboutTelemetry.js
@@ -1984,36 +1984,16 @@ var KeyedHistogramSection = {
           KeyedHistogram.render(keyedDiv, id, keyed, {unpacked: true});
         }
       }
       setHasData("keyed-histograms-section", hasData || keyedHgramsSelect.options.length);
     }
   },
 }
 
-var AddonHistogramSection = {
-  render(aPayload) {
-    let addonDiv = document.getElementById("addon-histograms");
-    removeAllChildNodes(addonDiv);
-
-    let addonHistogramsRendered = false;
-    let addonData = aPayload.addonHistograms;
-    if (addonData) {
-      for (let [addon, histograms] of Object.entries(addonData)) {
-        for (let [name, hgram] of Object.entries(histograms)) {
-          addonHistogramsRendered = true;
-          Histogram.render(addonDiv, addon + ": " + name, hgram, {unpacked: true});
-        }
-      }
-    }
-
-    setHasData("addon-histograms-section", addonHistogramsRendered);
-  },
-}
-
 var SessionInformation = {
   render(aPayload) {
     let infoSection = document.getElementById("session-info");
     removeAllChildNodes(infoSection);
 
     let hasData = Object.keys(aPayload.info).length > 0;
     setHasData("session-info-section", hasData);
 
@@ -2245,14 +2225,11 @@ function displayRichPingData(ping, updat
   // Show histogram data
   HistogramSection.render(payload);
 
   // Show keyed histogram data
   KeyedHistogramSection.render(payload);
 
   // Show event data.
   Events.render(payload);
-
-  // Show addon histogram data
-  AddonHistogramSection.render(payload);
 }
 
 window.addEventListener("load", onLoad);
--- a/toolkit/content/aboutTelemetry.xhtml
+++ b/toolkit/content/aboutTelemetry.xhtml
@@ -71,19 +71,16 @@
         <span class="category-name">&aboutTelemetry.threadHangStatsSection;</span>
       </div>
       <div class="category" value="late-writes-section">
         <span class="category-name">&aboutTelemetry.lateWritesSection;</span>
       </div>
       <div class="category" value="addon-details-section">
         <span class="category-name">&aboutTelemetry.addonDetailsSection;</span>
       </div>
-      <div class="category" value="addon-histograms-section">
-        <span class="category-name">&aboutTelemetry.addonHistogramsSection;</span>
-      </div>
       <div class="category" value="captured-stacks-section">
         <span class="category-name">&aboutTelemetry.capturedStacksSection;</span>
       </div>
       <div class="category" value="late-writes-section">
         <span class="category-name">&aboutTelemetry.lateWritesSection;</span>
       </div>
       <div id="category-raw" class="category has-data" value="raw-ping-data-section">
           <span class="category-name">&aboutTelemetry.raw;</span>
@@ -268,22 +265,16 @@
       </section>
 
       <section id="addon-details-section" class="tab data-section expanded" hidden="true">
         <input type="checkbox" class="statebox"/>
         <div id="addon-details" class="data">
         </div>
       </section>
 
-      <section id="addon-histograms-section" class="tab data-section expanded" hidden="true">
-        <input type="checkbox" class="statebox"/>
-        <div id="addon-histograms" class="data">
-        </div>
-      </section>
-
       <section id="captured-stacks-section" class="tab data-section expanded" hidden="true">
         <input type="checkbox" class="statebox"/>
         <div id="captured-stacks" class="data">
           <a id="captured-stacks-fetch-symbols" href="#">&aboutTelemetry.fetchStackSymbols;</a>
           <a id="captured-stacks-hide-symbols" class="hidden" href="#">&aboutTelemetry.hideStackSymbols;</a>
           <br/>
           <br/>
           <div id="captured-stacks-data">
--- a/toolkit/locales/en-US/chrome/global/aboutTelemetry.dtd
+++ b/toolkit/locales/en-US/chrome/global/aboutTelemetry.dtd
@@ -103,20 +103,16 @@ Ping
 <!ENTITY aboutTelemetry.lateWritesSection "
   Late Writes
 ">
 
 <!ENTITY aboutTelemetry.sessionInfoSection "
   Session Information
 ">
 
-<!ENTITY aboutTelemetry.addonHistogramsSection "
-  Histograms Collected by Add-ons
-">
-
 <!ENTITY aboutTelemetry.fullSqlWarning "
   NOTE: Slow SQL debugging is enabled. Full SQL strings may be displayed below but they will not be submitted to Telemetry.
 ">
 
 <!ENTITY aboutTelemetry.fetchStackSymbols "
   Fetch function names for stacks
 ">