Bug 1354515 - Removed duplicate ESLint rules in security/manager r?Standard8 draft
authorRajesh Kathiriya <rajesh.kathiriya507@gmail.com>
Sat, 22 Apr 2017 15:41:34 +0530
changeset 567239 2d0daecaf5c7cd41f829a90a49e427e850cb7d8b
parent 566736 42c8a716081e6a8aa33c1e61944f36f6f89245fb
child 625566 66c953262dec2231279ecb2ad4cb34c56dfa957a
push id55486
push userbmo:rajesh.kathiriya507@gmail.com
push dateMon, 24 Apr 2017 15:16:17 +0000
reviewersStandard8
bugs1354515
milestone55.0a1
Bug 1354515 - Removed duplicate ESLint rules in security/manager r?Standard8 MozReview-Commit-ID: 8H7iE1wu2hW
security/manager/.eslintrc.js
--- a/security/manager/.eslintrc.js
+++ b/security/manager/.eslintrc.js
@@ -21,28 +21,19 @@ module.exports = {
     "curly": ["error", "multi-line"],
 
     // Require default case in switch statements.
     "default-case": "error",
 
     // Require `foo.bar` dot notation instead of `foo["bar"]` notation.
     "dot-notation": "error",
 
-    // Always require a trailing EOL
-    "eol-last": "error",
-
-    // No spaces between function name and parentheses.
-    "func-call-spacing": ["error", "never"],
-
     // Require function* name()
     "generator-star-spacing": ["error", {"before": false, "after": true}],
 
-    // Space after colon not before in property declarations
-    "key-spacing": ["error", { "beforeColon": false, "afterColon": true, "mode": "minimum" }],
-
     // Always require parenthesis for new calls
     "new-parens": "error",
 
     // Disallow use of alert(), confirm(), and prompt().
     "no-alert": "error",
 
     // Use [] instead of Array()
     "no-array-constructor": "error",
@@ -80,19 +71,16 @@ module.exports = {
 
     // Disallow case statement fallthrough without explicit `// falls through`
     // annotation.
     "no-fallthrough": "error",
 
     // No reassigning native JS objects or read only globals.
     "no-global-assign": "error",
 
-    // Disallow implied eval().
-    "no-implied-eval": "error",
-
     // Disallow primitive wrapper instances like `new Boolean(false)`, which
     // seem like they should act like primitives but don't.
     "no-new-wrappers": "error",
 
     // Disallow use of assignment in return statement.
     "no-return-assign": ["error", "always"],
 
     // Disallow use of the comma operator.
@@ -106,19 +94,16 @@ module.exports = {
 
     // Disallow use of this/super before calling super() in constructors.
     "no-this-before-super": "error",
 
     // Disallow throwing literals (eg. |throw "error"| instead of
     // |throw new Error("error")|)
     "no-throw-literal": "error",
 
-    // No using undeclared variables
-    "no-undef": "error",
-
     // Disallow unmodified loop conditions.
     "no-unmodified-loop-condition": "error",
 
     // Disallow ternary operators when simpler alternatives exist.
     "no-unneeded-ternary": "error",
 
     // No expressions where a statement is expected
     "no-unused-expressions": "error",
@@ -144,33 +129,25 @@ module.exports = {
       "anonymous": "ignore",
       "asyncArrow": "always",
       "named": "never",
     }],
 
     // No space padding in parentheses
     "space-in-parens": ["error", "never"],
 
-    // Require spaces around operators
-    "space-infix-ops": "error",
-
     // ++ and -- should not need spacing
     "space-unary-ops": ["error", { "words": true, "nonwords": false }],
 
     // Require "use strict" to be defined globally in the script.
     "strict": ["error", "global"],
 
     // Enforce valid JSDoc comments.
     "valid-jsdoc": ["error", {
       "requireParamDescription": false,
       "requireReturn": false,
       "requireReturnDescription": false,
     }],
 
     // Disallow Yoda conditions.
     "yoda": ["error", "never"],
-  },
-
-  "globals": {
-    "Components": false,
-    "dump": false
   }
 };