Bug 1354761 - Avoid calling goNext inside BTU.withNewTab in browser_popupNotification_keyboard.js. r=nihanth draft
authorJohann Hofmann <jhofmann@mozilla.com>
Thu, 20 Apr 2017 15:20:21 +0200
changeset 565788 b8c6fbf13e7e1d24cee00ef785edc087c354b72c
parent 565752 27311156637f9b5d4504373967e01c4241902ae7
child 625126 fbac20499344a4783b18b532c8a3fa916f3b79a5
push id55012
push userbmo:jhofmann@mozilla.com
push dateThu, 20 Apr 2017 13:20:49 +0000
reviewersnihanth
bugs1354761
milestone55.0a1
Bug 1354761 - Avoid calling goNext inside BTU.withNewTab in browser_popupNotification_keyboard.js. r=nihanth This was likely the cause of intermittent failures reporting dangling tabs at the end of the test. MozReview-Commit-ID: Cq07ALUGiFI
browser/base/content/test/popupNotifications/browser_popupNotification_keyboard.js
--- a/browser/base/content/test/popupNotifications/browser_popupNotification_keyboard.js
+++ b/browser/base/content/test/popupNotifications/browser_popupNotification_keyboard.js
@@ -196,13 +196,13 @@ var tests = [
         }
 
         // Check that the input field is still focused inside the browser.
         yield ContentTask.spawn(browser, {}, function() {
           is(content.document.activeElement, content.document.getElementById("test-input"));
         });
 
         notification.remove();
-        goNext();
       });
+      goNext();
     },
   },
 ];