Bug 1357745 - Disable the shutdown ping sender. r?gfritzsche draft
authorAlessio Placitelli <alessio.placitelli@gmail.com>
Wed, 19 Apr 2017 16:11:49 +0200
changeset 565077 f7a2be3d12c2931358039b973e48a58bf706ecdf
parent 564098 bb38d935d699e0529f9e0bb35578d381026415c4
child 624918 0726e4f88f2a57f5a9d587490b123928d0b3288d
push id54788
push useralessio.placitelli@gmail.com
push dateWed, 19 Apr 2017 14:12:44 +0000
reviewersgfritzsche
bugs1357745
milestone55.0a1
Bug 1357745 - Disable the shutdown ping sender. r?gfritzsche MozReview-Commit-ID: 8HhOYNrxOkn
toolkit/components/telemetry/TelemetrySession.jsm
--- a/toolkit/components/telemetry/TelemetrySession.jsm
+++ b/toolkit/components/telemetry/TelemetrySession.jsm
@@ -1791,17 +1791,19 @@ var Impl = {
     // on both to be saved after kicking off their collection.
     let p = [];
 
     if (IS_UNIFIED_TELEMETRY) {
       let shutdownPayload = this.getSessionPayload(REASON_SHUTDOWN, false);
 
       // Only send the shutdown ping using the pingsender from the second
       // browsing session on, to mitigate issues with "bot" profiles (see bug 1354482).
-      let sendWithPingsender = Preferences.get(PREF_SHUTDOWN_PINGSENDER, true) &&
+      // Note: sending the "shutdown" ping using the pingsender is currently disabled
+      // due to a crash happening on OSX platforms. See bug 1357745 for context.
+      let sendWithPingsender = Preferences.get(PREF_SHUTDOWN_PINGSENDER, false) &&
                                !TelemetryReportingPolicy.isFirstRun();
 
       let options = {
         addClientId: true,
         addEnvironment: true,
         usePingSender: sendWithPingsender,
       };
       p.push(TelemetryController.submitExternalPing(getPingType(shutdownPayload), shutdownPayload, options)