Bug 1341703 - Part 1. Make sure that the URL stylo parse for border-image-source is propagated to Gecko computed style. draft
authorcku <cku@mozilla.com>
Mon, 17 Apr 2017 13:29:39 +0800
changeset 565189 4b83500a4afafa1739686f03db580c3d3b3162e6
parent 565030 c0ea5ed7f91a6be996a4a3c5ab25e2cdf6b4377e
child 565190 2acc71c009c277b476ec454ae66affa39b3cf724
push id54804
push userbmo:cku@mozilla.com
push dateWed, 19 Apr 2017 15:30:23 +0000
bugs1341703
milestone55.0a1
Bug 1341703 - Part 1. Make sure that the URL stylo parse for border-image-source is propagated to Gecko computed style. MozReview-Commit-ID: LWFsQzVg46z
servo/components/style/properties/gecko.mako.rs
--- a/servo/components/style/properties/gecko.mako.rs
+++ b/servo/components/style/properties/gecko.mako.rs
@@ -908,19 +908,17 @@ fn static_assert() {
 
     pub fn set_border_image_source(&mut self, v: longhands::border_image_source::computed_value::T) {
         unsafe {
             // Prevent leaking of the last elements we did set
             Gecko_SetNullImageValue(&mut self.gecko.mBorderImageSource);
         }
 
         if let Some(image) = v.0 {
-            // TODO: We need to make border-image-source match with background-image
-            // until then we are setting with_url to false
-            self.gecko.mBorderImageSource.set(image, false, &mut false)
+            self.gecko.mBorderImageSource.set(image, true, &mut false)
         }
     }
 
     pub fn copy_border_image_source_from(&mut self, other: &Self) {
         unsafe {
             Gecko_CopyImageValueFrom(&mut self.gecko.mBorderImageSource,
                                      &other.gecko.mBorderImageSource);
         }