Bug 1356898 - Use nsAutoCString in two places in TelemetryHistogram.cpp. r?froydnj draft
authorMarkus Stange <mstange@themasta.com>
Sun, 16 Apr 2017 14:18:00 -0400
changeset 563387 ae8277b746f9dcbc38fcf53bf3a92e7cb2daeff0
parent 563386 d884fb5f766aceb691137adfed91f5e9332d3793
child 624452 0c3f4e90c78f8996d2afd1a1f1ad9dd07f069856
push id54277
push userbmo:mstange@themasta.com
push dateSun, 16 Apr 2017 18:18:18 +0000
reviewersfroydnj
bugs1356898
milestone55.0a1
Bug 1356898 - Use nsAutoCString in two places in TelemetryHistogram.cpp. r?froydnj MozReview-Commit-ID: 3njPBvdhwRj
toolkit/components/telemetry/TelemetryHistogram.cpp
--- a/toolkit/components/telemetry/TelemetryHistogram.cpp
+++ b/toolkit/components/telemetry/TelemetryHistogram.cpp
@@ -494,17 +494,17 @@ internal_GetHistogramByEnumId(mozilla::T
     return NS_OK;
   }
 
   const HistogramInfo &p = gHistograms[id];
   if (p.keyed) {
     return NS_ERROR_FAILURE;
   }
 
-  nsCString histogramName;
+  nsAutoCString histogramName;
   histogramName.Append(p.id());
   if (const char* suffix = SuffixForProcessType(aProcessType)) {
     histogramName.AppendASCII(suffix);
   }
 
   nsresult rv = internal_HistogramGet(histogramName.get(), p.expiration(),
                                       p.histogramType, p.min, p.max,
                                       p.bucketCount, true, &h);
@@ -1398,17 +1398,17 @@ internal_AccumulateChildKeyed(GeckoProce
   const char* suffix = SuffixForProcessType(aProcessType);
   if (!suffix) {
     MOZ_ASSERT_UNREACHABLE("suffix should not be null");
     return;
   }
 
   const HistogramInfo& th = gHistograms[aId];
 
-  nsCString id;
+  nsAutoCString id;
   id.Append(th.id());
   id.AppendASCII(suffix);
 
   KeyedHistogram* keyed = internal_GetKeyedHistogramById(id);
   MOZ_ASSERT(keyed);
   keyed->Add(aKey, aSample);
 }