Bug 1356843 - Fix -Wcomma warning in tools/profiler/lul/LulDwarf.cpp. r?jseward draft
authorChris Peterson <cpeterson@mozilla.com>
Sun, 09 Apr 2017 21:43:29 -0700
changeset 563969 d9d54cc31e92ebf0e07aee98daff3958e040d6cc
parent 563968 5b5028c76ccfca2ab2cb5eea66c1c6719ef1a429
child 624639 e8e8527429bd09edf8d8a5b13eeda98ae65e95fd
push id54487
push usercpeterson@mozilla.com
push dateTue, 18 Apr 2017 06:09:29 +0000
reviewersjseward
bugs1356843
milestone55.0a1
Bug 1356843 - Fix -Wcomma warning in tools/profiler/lul/LulDwarf.cpp. r?jseward clang's -Wcomma warning warns about suspicious use of the comma operator such as between two statements. tools/profiler/lul/LulDwarf.cpp:604:15: warning: possible misuse of comma operator here [-Wcomma] MozReview-Commit-ID: 6ZP79hgtrAD
tools/profiler/lul/LulDwarf.cpp
--- a/tools/profiler/lul/LulDwarf.cpp
+++ b/tools/profiler/lul/LulDwarf.cpp
@@ -596,17 +596,17 @@ bool CallFrameInfo::RuleMap::HandleTrans
       // state, and there's no way to remove entries.
       MOZ_ASSERT(0);
     } else {
       // Both maps have an entry for this register. Report the new
       // rule if it is different.
       if (*old_it->second != *new_it->second &&
           !new_it->second->Handle(handler, address, new_it->first))
         return false;
-      new_it++, old_it++;
+      new_it++; old_it++;
     }
   }
   // Finish off entries from this RuleMap with no counterparts in new_rules.
   while (old_it != registers_.end()) {
     if (!handler->SameValueRule(address, old_it->first))
       return false;
     old_it++;
   }