Bug 1341372 - Part 8: Rename needs_update_animations. draft
authorBoris Chiou <boris.chiou@gmail.com>
Fri, 14 Apr 2017 10:44:38 +0800
changeset 563352 95749c12bdd6da38df977e57d6adbc557dadf177
parent 563351 9d92760cc6aa2465ced080040e445a71202823f4
child 563353 c4de49e4fa010067a31d269f22a51a3dc68b8bbe
push id54259
push userbmo:boris.chiou@gmail.com
push dateSun, 16 Apr 2017 06:29:51 +0000
bugs1341372
milestone55.0a1
Bug 1341372 - Part 8: Rename needs_update_animations. MozReview-Commit-ID: 2bJlBbdX543
servo/components/style/matching.rs
--- a/servo/components/style/matching.rs
+++ b/servo/components/style/matching.rs
@@ -527,17 +527,17 @@ trait PrivateMatchMethods: TElement {
                                      &context.thread_local.font_metrics_provider,
                                      &without_transition_rules,
                                      primary_style,
                                      cascade_flags,
                                      pseudo_style.is_some()))
     }
 
     #[cfg(feature = "gecko")]
-    fn needs_update_animations(&self,
+    fn needs_animations_update(&self,
                                old_values: &Option<Arc<ComputedValues>>,
                                new_values: &Arc<ComputedValues>,
                                pseudo: Option<&PseudoElement>) -> bool {
         let ref new_box_style = new_values.get_box();
         let has_new_animation_style = new_box_style.animation_name_count() >= 1 &&
                                       new_box_style.animation_name_at(0).0.len() != 0;
         let has_animations = self.has_css_animations(pseudo);
 
@@ -563,17 +563,17 @@ trait PrivateMatchMethods: TElement {
                           new_values: &mut Arc<ComputedValues>,
                           primary_style: &ComputedStyle,
                           pseudo_style: &Option<(&PseudoElement, &ComputedStyle)>) {
         use context::{CSS_ANIMATIONS, CSS_TRANSITIONS, EFFECT_PROPERTIES};
         use context::UpdateAnimationsTasks;
 
         let pseudo = pseudo_style.map(|(p, _)| p);
         let mut tasks = UpdateAnimationsTasks::empty();
-        if self.needs_update_animations(old_values, new_values, pseudo) {
+        if self.needs_animations_update(old_values, new_values, pseudo) {
             tasks.insert(CSS_ANIMATIONS);
         }
 
         let before_change_style = if self.might_need_transitions_update(&old_values.as_ref(),
                                                                         new_values,
                                                                         pseudo) {
             let after_change_style = if self.has_css_transitions(pseudo) {
                 self.get_after_change_style(context, primary_style, pseudo_style)