bug 1347677 - Use BrowserTestUtils.waitForErrorPage in browser_bug431826.js. r?johannh draft
authorDan Banner <dbugs@thebanners.uk>
Thu, 13 Apr 2017 13:58:00 +0100
changeset 562047 eca685a8ddf9916f220bbc0bd540d16acd8d62f5
parent 561911 819a666afddc804b6099ee1b3cff3a0fdf35ec15
child 624165 62a211976c8b6e8cce6719fd0059a0dedce35c22
push id53948
push userbmo:dbugs@thebanners.uk
push dateThu, 13 Apr 2017 13:03:00 +0000
reviewersjohannh
bugs1347677, 431826
milestone55.0a1
bug 1347677 - Use BrowserTestUtils.waitForErrorPage in browser_bug431826.js. r?johannh MozReview-Commit-ID: AnDGq52UfPM
browser/base/content/test/general/browser_bug431826.js
--- a/browser/base/content/test/general/browser_bug431826.js
+++ b/browser/base/content/test/general/browser_bug431826.js
@@ -1,20 +1,16 @@
 function remote(task) {
   return ContentTask.spawn(gBrowser.selectedBrowser, null, task);
 }
 
 add_task(function* () {
   gBrowser.selectedTab = gBrowser.addTab();
 
-  let promise = remote(function() {
-    return ContentTaskUtils.waitForEvent(this, "DOMContentLoaded", true, event => {
-      return content.document.documentURI != "about:blank";
-    }).then(() => 0); // don't want to send the event to the chrome process
-  });
+  let promise = BrowserTestUtils.waitForErrorPage(gBrowser.selectedBrowser);
   gBrowser.loadURI("https://nocert.example.com/");
   yield promise;
 
   yield remote(() => {
     // Confirm that we are displaying the contributed error page, not the default
     let uri = content.document.documentURI;
     Assert.ok(uri.startsWith("about:certerror"), "Broken page should go to about:certerror, not about:neterror");
   });
@@ -25,19 +21,17 @@ add_task(function* () {
     Assert.ok(div, "Advanced content div should exist");
     Assert.equal(div.ownerGlobal.getComputedStyle(div).display,
       "none", "Advanced content should not be visible by default");
   });
 
   // Tweak the expert mode pref
   gPrefService.setBoolPref("browser.xul.error_pages.expert_bad_cert", true);
 
-  promise = remote(function() {
-    return ContentTaskUtils.waitForEvent(this, "DOMContentLoaded", true);
-  });
+  promise = BrowserTestUtils.waitForErrorPage(gBrowser.selectedBrowser);
   gBrowser.reload();
   yield promise;
 
   yield remote(() => {
     let div = content.document.getElementById("badCertAdvancedPanel");
     Assert.ok(div, "Advanced content div should exist");
     Assert.equal(div.ownerGlobal.getComputedStyle(div).display,
       "block", "Advanced content should be visible by default");