Bug 1351586 - AudioSink constructor should take a const reference instead of value of TimeUnit. r?kaku draft
authorJW Wang <jwwang@mozilla.com>
Wed, 12 Apr 2017 16:43:05 +0800
changeset 561715 d8e14bf52d635a6a6969c8032a850965fdc66ff7
parent 561714 74a785ce7d41e9b351c437b8c511222d0f04d1fa
child 561716 59b54419549d8d1e1fc50ae29aca80173cdee475
push id53821
push userjwwang@mozilla.com
push dateThu, 13 Apr 2017 03:37:28 +0000
reviewerskaku
bugs1351586
milestone55.0a1
Bug 1351586 - AudioSink constructor should take a const reference instead of value of TimeUnit. r?kaku MozReview-Commit-ID: F95iIsVealk
dom/media/mediasink/AudioSink.cpp
dom/media/mediasink/AudioSink.h
--- a/dom/media/mediasink/AudioSink.cpp
+++ b/dom/media/mediasink/AudioSink.cpp
@@ -28,17 +28,17 @@ namespace media {
 // The amount of audio frames that is used to fuzz rounding errors.
 static const int64_t AUDIO_FUZZ_FRAMES = 1;
 
 // Amount of audio frames we will be processing ahead of use
 static const int32_t LOW_AUDIO_USECS = 300000;
 
 AudioSink::AudioSink(AbstractThread* aThread,
                      MediaQueue<AudioData>& aAudioQueue,
-                     TimeUnit aStartTime,
+                     const TimeUnit& aStartTime,
                      const AudioInfo& aInfo,
                      dom::AudioChannel aChannel)
   : mStartTime(aStartTime)
   , mInfo(aInfo)
   , mChannel(aChannel)
   , mPlaying(true)
   , mMonitor("AudioSink")
   , mWritten(0)
--- a/dom/media/mediasink/AudioSink.h
+++ b/dom/media/mediasink/AudioSink.h
@@ -27,17 +27,17 @@ class AudioConverter;
 namespace media {
 
 class AudioSink : private AudioStream::DataSource {
   using PlaybackParams = MediaSink::PlaybackParams;
 
 public:
   AudioSink(AbstractThread* aThread,
             MediaQueue<AudioData>& aAudioQueue,
-            TimeUnit aStartTime,
+            const TimeUnit& aStartTime,
             const AudioInfo& aInfo,
             dom::AudioChannel aChannel);
 
   ~AudioSink();
 
   // Return a promise which will be resolved when AudioSink
   // finishes playing, or rejected if any error.
   RefPtr<GenericPromise> Init(const PlaybackParams& aParams);