Bug 1341996 - Prevent using empty keys in DEVTOOLS_JAVASCRIPT_ERROR_DISPLAYED. r?bgrins draft
authorAlessio Placitelli <alessio.placitelli@gmail.com>
Wed, 12 Apr 2017 17:33:36 +0200
changeset 561827 dbd2ef9beac643d944da26d763c14ca9e56f6df7
parent 560921 f40e24f40b4c4556944c762d4764eace261297f5
child 624103 cea7c0bd5e5b9a2cab003c5e140bc43642eeab37
push id53879
push useralessio.placitelli@gmail.com
push dateThu, 13 Apr 2017 07:48:36 +0000
reviewersbgrins
bugs1341996
milestone55.0a1
Bug 1341996 - Prevent using empty keys in DEVTOOLS_JAVASCRIPT_ERROR_DISPLAYED. r?bgrins MozReview-Commit-ID: 42ESILTpnAT
devtools/client/webconsole/webconsole.js
--- a/devtools/client/webconsole/webconsole.js
+++ b/devtools/client/webconsole/webconsole.js
@@ -1528,17 +1528,17 @@ WebConsoleFrame.prototype = {
 
     // Add the more info link node to messages that belong to certain categories
     if (scriptError.exceptionDocURL) {
       this.addLearnMoreWarningNode(msgBody, scriptError.exceptionDocURL);
     }
 
     // Collect telemetry data regarding JavaScript errors
     this._telemetry.logKeyed("DEVTOOLS_JAVASCRIPT_ERROR_DISPLAYED",
-                             scriptError.errorMessageName,
+                             scriptError.errorMessageName || "Unknown",
                              true);
 
     if (objectActors.size > 0) {
       node._objectActors = objectActors;
     }
 
     return node;
   },