Bug 1355010: temporarily turn off extmap direction verification to avoid Chrome interop issues. r?bwc draft
authorNils Ohlmeier [:drno] <drno@ohlmeier.org>
Tue, 11 Apr 2017 14:08:32 -0700
changeset 560699 c83da5ed48ccaec250de8a07e883759bfc480e4b
parent 560546 abf145ebd05fe105efbc78b761858c34f7690154
child 623792 84d8c03684d795fb142383c26be3721ddf253ca1
push id53524
push userdrno@ohlmeier.org
push dateTue, 11 Apr 2017 21:08:47 +0000
reviewersbwc
bugs1355010
milestone55.0a1
Bug 1355010: temporarily turn off extmap direction verification to avoid Chrome interop issues. r?bwc MozReview-Commit-ID: 76Zayg9XMi7
media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp
--- a/media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp
+++ b/media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp
@@ -2068,22 +2068,25 @@ JsepSessionImpl::ValidateAnswer(const Sd
       }
 
       for (const auto& ansExt : answerAttrs.GetExtmap().mExtmaps) {
         bool found = false;
         for (const auto& offExt : offerAttrs.GetExtmap().mExtmaps) {
           if (ansExt.extensionname == offExt.extensionname) {
             if ((ansExt.direction & reverse(offExt.direction))
                   != ansExt.direction) {
-              JSEP_SET_ERROR("Answer has inconsistent direction on extmap "
+              // FIXME we do not return an error here, because Chrome up to
+              // version 57 is actually tripping over this if they are the
+              // answerer. See bug 1355010 for details.
+              MOZ_MTLOG(ML_WARNING, "Answer has inconsistent direction on extmap "
                              "attribute at level " << i << " ("
                              << ansExt.extensionname << "). Offer had "
                              << offExt.direction << ", answer had "
                              << ansExt.direction << ".");
-              return NS_ERROR_INVALID_ARG;
+              // return NS_ERROR_INVALID_ARG;
             }
 
             if (offExt.entry < 4096 && (offExt.entry != ansExt.entry)) {
               JSEP_SET_ERROR("Answer changed id for extmap attribute at level "
                              << i << " (" << offExt.extensionname << ") from "
                              << offExt.entry << " to " << ansExt.entry << ".");
               return NS_ERROR_INVALID_ARG;
             }