Bug 1322650 - Don't use inout param for Surface in ICodec r=jolin draft
authorJames Willcox <snorp@snorp.net>
Fri, 03 Mar 2017 15:19:04 -0600
changeset 560661 7e7ab3d88008cabd0f0eaacf76a5b9a194072c48
parent 560660 d71a2b3d1e8c290777caad6816a621066ece3272
child 560662 5d7ec5b7c8f3b51e5ec778beebc2d85b688cda3c
push id53500
push userbmo:snorp@snorp.net
push dateTue, 11 Apr 2017 19:09:24 +0000
reviewersjolin
bugs1322650
milestone55.0a1
Bug 1322650 - Don't use inout param for Surface in ICodec r=jolin It's unnecessary, and the serialization goes wrong with GeckoSurface on the return trip. MozReview-Commit-ID: 9DUMoLQFhlv
mobile/android/geckoview/src/main/aidl/org/mozilla/gecko/media/ICodec.aidl
--- a/mobile/android/geckoview/src/main/aidl/org/mozilla/gecko/media/ICodec.aidl
+++ b/mobile/android/geckoview/src/main/aidl/org/mozilla/gecko/media/ICodec.aidl
@@ -8,17 +8,17 @@ package org.mozilla.gecko.media;
 import android.os.Bundle;
 import android.view.Surface;
 import org.mozilla.gecko.media.FormatParam;
 import org.mozilla.gecko.media.ICodecCallbacks;
 import org.mozilla.gecko.media.Sample;
 
 interface ICodec {
     void setCallbacks(in ICodecCallbacks callbacks);
-    boolean configure(in FormatParam format, inout Surface surface, int flags, in String drmStubId);
+    boolean configure(in FormatParam format, in Surface surface, int flags, in String drmStubId);
     boolean isAdaptivePlaybackSupported();
     void start();
     void stop();
     void flush();
     void release();
 
     Sample dequeueInput(int size);
     oneway void queueInput(in Sample sample);