Bug 1354887 - The Tracking Protection exceptions and block list dialogs should always be visible within the tracking protection section. r?mconley draft
authorJared Wein <jwein@mozilla.com>
Tue, 11 Apr 2017 10:41:39 -0400
changeset 560508 f4f09259920e3d64211f71216a193296703c4809
parent 560121 fc150090ef51f53e8523a583e031910b364d36f8
child 623725 ce2c2b238f6eead13dd0033122178f1cbba2ef3a
push id53446
push userbmo:jaws@mozilla.com
push dateTue, 11 Apr 2017 14:52:31 +0000
reviewersmconley
bugs1354887
milestone55.0a1
Bug 1354887 - The Tracking Protection exceptions and block list dialogs should always be visible within the tracking protection section. r?mconley A couple other hidden="false" attributes were removed since they are unnecessary and shouldn't have been there. The changes to the downloadsGroup are because it is now nested inside of #applicationsContent. MozReview-Commit-ID: IHZuKZUNYcR
browser/components/preferences/in-content/applications.xul
browser/components/preferences/in-content/privacy.xul
--- a/browser/components/preferences/in-content/applications.xul
+++ b/browser/components/preferences/in-content/applications.xul
@@ -68,19 +68,17 @@
 </hbox>
 
 <vbox id="applicationsContent"
       data-category="paneApplications"
       hidden="true"
       flex="1">
 
   <!--Downloads-->
-  <groupbox id="downloadsGroup"
-            data-category="paneApplications"
-            hidden="false">
+  <groupbox id="downloadsGroup">
     <caption><label>&downloads.label;</label></caption>
 
     <radiogroup id="saveWhere"
                 preference="browser.download.useDownloadDir"
                 onsyncfrompreference="return gApplicationsPane.readUseDownloadDir();">
       <hbox id="saveToRow">
         <radio id="saveTo"
               value="true"
--- a/browser/components/preferences/in-content/privacy.xul
+++ b/browser/components/preferences/in-content/privacy.xul
@@ -330,17 +330,17 @@
     </rows>
   </grid>
 </groupbox>
 
 <!-- Tracking -->
 <groupbox id="trackingGroup" data-category="panePrivacy" hidden="true">
   <vbox id="trackingprotectionbox" hidden="true">
     <hbox align="start">
-      <vbox hidden="false">
+      <vbox>
         <caption><label>&trackingProtectionHeader2.label;
           <label id="trackingProtectionLearnMore" class="learnMore text-link"
                  value="&trackingProtectionLearnMore.label;"/>
         </label></caption>
         <radiogroup id="trackingProtectionRadioGroup">
           <radio value="always"
                  label="&trackingProtectionAlways.label;"
                  accesskey="&trackingProtectionAlways.accesskey;"/>
@@ -348,17 +348,17 @@
                  label="&trackingProtectionPrivate.label;"
                  accesskey="&trackingProtectionPrivate.accesskey;"/>
           <radio value="never"
                  label="&trackingProtectionNever.label;"
                  accesskey="&trackingProtectionNever.accesskey;"/>
         </radiogroup>
       </vbox>
       <spacer flex="1" />
-      <vbox hidden="true">
+      <vbox>
         <button id="trackingProtectionExceptions"
                 label="&trackingProtectionExceptions.label;"
                 accesskey="&trackingProtectionExceptions.accesskey;"
                 preference="pref.privacy.disable_button.tracking_protection_exceptions"/>
         <button id="changeBlockList"
                 label="&changeBlockList.label;"
                 accesskey="&changeBlockList.accesskey;"
                 preference="pref.privacy.disable_button.change_blocklist"/>
@@ -376,17 +376,17 @@
              class="learnMore text-link"
              value="&trackingProtectionPBMLearnMore.label;"/>
       <spacer flex="1" />
       <button id="changeBlockListPBM"
               label="&changeBlockList.label;" accesskey="&changeBlockList.accesskey;"
               preference="pref.privacy.disable_button.change_blocklist"/>
     </hbox>
   </vbox>
-  <vbox hidden="false">
+  <vbox>
     <description>&doNotTrack.pre.label;<label
     class="text-link" id="doNotTrackSettings"
     >&doNotTrack.settings.label;</label>&doNotTrack.post.label;</description>
   </vbox>
 </groupbox>
 
 <!-- Pop-ups -->
 <groupbox id="miscGroup" data-category="panePrivacy" hidden="true">