Bug 1349004 part 1 - Rename ResolveServoStyle to ResolveServoStyleWithoutSyncUpData r?hiro draft
authorMantaroh Yoshinaga <mantaroh@gmail.com>
Mon, 10 Apr 2017 15:10:37 +0900
changeset 559450 c35174346d2ba7a1d82115bf782634799f9b1d56
parent 559365 45692c884fdd5136a64fb2f8a61a0c8183b69331
child 559451 edae685da2271e729ffd66f408599e43eb9041b7
push id53097
push userbmo:mantaroh@gmail.com
push dateMon, 10 Apr 2017 06:12:11 +0000
reviewershiro
bugs1349004
milestone55.0a1
Bug 1349004 part 1 - Rename ResolveServoStyle to ResolveServoStyleWithoutSyncUpData r?hiro MozReview-Commit-ID: 6APiOGUn149
layout/base/ServoRestyleManager.cpp
layout/style/ServoStyleSet.cpp
layout/style/ServoStyleSet.h
--- a/layout/base/ServoRestyleManager.cpp
+++ b/layout/base/ServoRestyleManager.cpp
@@ -184,17 +184,17 @@ ServoRestyleManager::ProcessPostTraversa
     displayContentsNode =
       PresContext()->FrameConstructor()->GetDisplayContentsNodeFor(aElement);
     if (displayContentsNode) {
       oldStyleContext = displayContentsNode->mStyle;
     }
   }
 
   RefPtr<ServoComputedValues> computedValues =
-    aStyleSet->ResolveServoStyle(aElement);
+    aStyleSet->ResolveServoStyleWithoutSyncUpData(aElement);
 
   // Note that we rely in the fact that we don't cascade pseudo-element styles
   // separately right now (that is, if a pseudo style changes, the normal style
   // changes too).
   //
   // Otherwise we should probably encode that information somehow to avoid
   // expensive checks in the common case.
   //
--- a/layout/style/ServoStyleSet.cpp
+++ b/layout/style/ServoStyleSet.cpp
@@ -149,17 +149,17 @@ ServoStyleSet::GetContext(nsIContent* aC
   Element* element = aContent->AsElement();
 
 
   PreTraverseSync();
   RefPtr<ServoComputedValues> computedValues;
   if (aMayCompute == LazyComputeBehavior::Allow) {
     computedValues = ResolveStyleLazily(element, nullptr);
   } else {
-    computedValues = ResolveServoStyle(element);
+    computedValues = ResolveServoStyleWithoutSyncUpData(element);
   }
 
   MOZ_ASSERT(computedValues);
   return GetContext(computedValues.forget(), aParentContext, aPseudoTag, aPseudoType,
                     element);
 }
 
 already_AddRefed<nsStyleContext>
@@ -831,17 +831,17 @@ ServoStyleSet::GetBaseComputedValuesForE
 void
 ServoStyleSet::RebuildData()
 {
   ClearNonInheritingStyleContexts();
   Servo_StyleSet_RebuildData(mRawSet.get());
 }
 
 already_AddRefed<ServoComputedValues>
-ServoStyleSet::ResolveServoStyle(Element* aElement)
+ServoStyleSet::ResolveServoStyleWithoutSyncUpData(Element* aElement)
 {
   return Servo_ResolveStyle(aElement, mRawSet.get(),
                             mAllowResolveStaleStyles).Consume();
 }
 
 void
 ServoStyleSet::ClearNonInheritingStyleContexts()
 {
--- a/layout/style/ServoStyleSet.h
+++ b/layout/style/ServoStyleSet.h
@@ -264,17 +264,17 @@ public:
    * recompute the default computed styles.
    */
   void RebuildData();
 
   /**
    * Resolve style for the given element, and return it as a
    * ServoComputedValues, not an nsStyleContext.
    */
-  already_AddRefed<ServoComputedValues> ResolveServoStyle(dom::Element* aElement);
+  already_AddRefed<ServoComputedValues> ResolveServoStyleWithoutSyncUpData(dom::Element* aElement);
 
   bool FillKeyframesForName(const nsString& aName,
                             const nsTimingFunction& aTimingFunction,
                             const ServoComputedValues* aComputedValues,
                             nsTArray<Keyframe>& aKeyframes);
 
   nsTArray<ComputedKeyframeValues>
   GetComputedKeyframeValuesFor(const nsTArray<Keyframe>& aKeyframes,