Bug 1354778 - Remove expired telemetry probes PLUGIN_ACTIVATION_COUNT and PLUGIN_TINY_CONTENT. r=bsmedberg
As of Firefox 52, Flash is the only NPAPI plugin ever activated. As a keyed histogram for all plugin names, PLUGIN_ACTIVATION_COUNT telemetry is unwieldy to view. We can use the BLOCKED_ON_PLUGIN_INSTANCE_INIT_MS telemetry probe's sample count to track the number of Flash instantiations.
MozReview-Commit-ID: 62iGNLQ0nnE
--- a/browser/modules/PluginContent.jsm
+++ b/browser/modules/PluginContent.jsm
@@ -532,23 +532,17 @@ PluginContent.prototype = {
case "PluginDisabled":
let manageLink = this.getPluginUI(plugin, "managePluginsLink");
this.addLinkClickCallback(manageLink, "forwardCallback", "managePlugins");
shouldShowNotification = true;
break;
case "PluginInstantiated":
- let key = this._getPluginInfo(plugin).pluginTag.niceName;
- Services.telemetry.getKeyedHistogramById("PLUGIN_ACTIVATION_COUNT").add(key);
shouldShowNotification = true;
- let pluginRect = plugin.getBoundingClientRect();
- if (pluginRect.width <= 5 && pluginRect.height <= 5) {
- Services.telemetry.getHistogramById("PLUGIN_TINY_CONTENT").add(1);
- }
break;
}
// Show the in-content UI if it's not too big. The crashed plugin handler already did this.
let overlay = this.getPluginUI(plugin, "main");
if (eventType != "PluginCrashed") {
if (overlay != null) {
this.setVisibility(plugin, overlay,
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -10512,25 +10512,16 @@
},
"GFX_CRASH": {
"expires_in_version": "never",
"kind": "enumerated",
"n_values": 100,
"releaseChannelCollection": "opt-out",
"description": "Graphics Crash Reason (...)"
},
- "PLUGIN_ACTIVATION_COUNT": {
- "alert_emails": ["cpeterson@mozilla.com"],
- "expires_in_version": "53",
- "kind": "count",
- "keyed": true,
- "releaseChannelCollection": "opt-out",
- "bug_numbers": [722110,1260065],
- "description": "Counts number of times a certain plugin has been activated."
- },
"SCROLL_INPUT_METHODS": {
"alert_emails": ["botond@mozilla.com"],
"bug_numbers": [1238137],
"expires_in_version": "60",
"kind": "enumerated",
"n_values": 64,
"description": "Count of scroll actions triggered by different input methods. See gfx/layers/apz/util/ScrollInputMethods.h for a list of possible values and their meanings."
},
@@ -10742,23 +10733,16 @@
},
"PLUGIN_BLOCKED_FOR_STABILITY": {
"alert_emails": ["cpeterson@mozilla.com"],
"expires_in_version": "52",
"kind": "count",
"bug_numbers": [1237198],
"description": "Count plugins blocked for stability"
},
- "PLUGIN_TINY_CONTENT": {
- "alert_emails": ["cpeterson@mozilla.com"],
- "expires_in_version": "52",
- "kind": "count",
- "bug_numbers": [1237198],
- "description": "Count tiny plugin content"
- },
"IPC_MESSAGE_SIZE": {
"alert_emails": ["wmccloskey@mozilla.com"],
"bug_numbers": [1260908],
"expires_in_version": "55",
"kind": "exponential",
"high": 8000000,
"n_buckets": 50,
"keyed": true,