Bug 1354222: fix log level casting warnings. r?erahm draft
authorNils Ohlmeier [:drno] <drno@ohlmeier.org>
Thu, 06 Apr 2017 11:00:35 -0700
changeset 557451 e65fe4fed02d9a56e0a0c64ed08093f7bf2b1490
parent 557282 facaf90aeaaf6d7cf5e2966f9f918319536bddea
child 623066 ce4c66caed3c1896caccdf5a4608054610beb6b7
push id52731
push userdrno@ohlmeier.org
push dateThu, 06 Apr 2017 21:21:06 +0000
reviewerserahm
bugs1354222
milestone55.0a1
Bug 1354222: fix log level casting warnings. r?erahm MozReview-Commit-ID: A6hnPD3NkYr
media/mtransport/logging.h
--- a/media/mtransport/logging.h
+++ b/media/mtransport/logging.h
@@ -7,23 +7,24 @@
 // Original author: ekr@rtfm.com
 
 #ifndef logging_h__
 #define logging_h__
 
 #include <sstream>
 #include "mozilla/Logging.h"
 
+#ifdef MOZILLA_INTERNAL_API
+
 #define ML_ERROR            mozilla::LogLevel::Error
 #define ML_WARNING          mozilla::LogLevel::Warning
 #define ML_NOTICE           mozilla::LogLevel::Info
 #define ML_INFO             mozilla::LogLevel::Debug
 #define ML_DEBUG            mozilla::LogLevel::Verbose
 
-#ifdef MOZILLA_INTERNAL_API
 #define MOZ_MTLOG_MODULE(n) \
   static mozilla::LogModule* getLogModule() {   \
     static mozilla::LazyLogModule log(n);       \
     return static_cast<mozilla::LogModule*>(log);      \
   }
 
 #define MOZ_MTLOG(level, b)                                       \
   do {                                                            \
@@ -34,26 +35,32 @@
     }                                                             \
   } while(0)
 #else
 // When building mtransport outside of XUL, for example in stand-alone gtests,
 // PR_Logging needs to be used instead of mozilla logging.
 
 #include "prlog.h"
 
+#define ML_ERROR            PR_LOG_ERROR
+#define ML_WARNING          PR_LOG_WARNING
+#define ML_NOTICE           PR_LOG_INFO
+#define ML_INFO             PR_LOG_DEBUG
+#define ML_DEBUG            PR_LOG_VERBOSE
+
 #define MOZ_MTLOG_MODULE(n) \
   static PRLogModuleInfo* getLogModule() {      \
     static PRLogModuleInfo* log;                \
     if (!log)                                   \
       log = PR_NewLogModule(n);                 \
     return log;                                 \
   }
 
 #define MOZ_MTLOG(level, b)                                                         \
   do {                                                                              \
-    if (PR_LOG_TEST(getLogModule(), (PRLogModuleLevel)level)) {                     \
+    if (PR_LOG_TEST(getLogModule(), level)) {                                       \
       std::stringstream str;                                                        \
       str << b;                                                                     \
-      PR_LOG(getLogModule(), (PRLogModuleLevel)level, ("%s", str.str().c_str()));   \
+      PR_LOG(getLogModule(), level, ("%s", str.str().c_str()));                     \
     }                                                                               \
   } while(0)
 #endif // MOZILLA_INTERNAL_API
 #endif // logging_h__