Bug 1351739 - Part -1 - Housekeeping. r?sebastian,walkingice
MozReview-Commit-ID: Ev6jl4N3K0g
--- a/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
+++ b/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
@@ -107,17 +107,16 @@ import org.mozilla.gecko.util.GeckoBundl
import org.mozilla.gecko.util.HardwareUtils;
import org.mozilla.gecko.util.IntentUtils;
import org.mozilla.gecko.util.MenuUtils;
import org.mozilla.gecko.util.PrefUtils;
import org.mozilla.gecko.util.StringUtils;
import org.mozilla.gecko.util.ThreadUtils;
import org.mozilla.gecko.widget.ActionModePresenter;
import org.mozilla.gecko.widget.AnchoredPopup;
-
import org.mozilla.gecko.widget.GeckoActionProvider;
import android.app.Activity;
import android.app.AlertDialog;
import android.app.Notification;
import android.app.NotificationManager;
import android.app.PendingIntent;
import android.content.ContentResolver;
--- a/mobile/android/base/java/org/mozilla/gecko/GeckoApp.java
+++ b/mobile/android/base/java/org/mozilla/gecko/GeckoApp.java
@@ -40,16 +40,19 @@ import org.mozilla.gecko.util.ActivityRe
import org.mozilla.gecko.util.ActivityUtils;
import org.mozilla.gecko.util.BundleEventListener;
import org.mozilla.gecko.util.EventCallback;
import org.mozilla.gecko.util.FileUtils;
import org.mozilla.gecko.util.GeckoBundle;
import org.mozilla.gecko.util.HardwareUtils;
import org.mozilla.gecko.util.PrefUtils;
import org.mozilla.gecko.util.ThreadUtils;
+import org.mozilla.gecko.util.ViewUtil;
+import org.mozilla.gecko.widget.ActionModePresenter;
+import org.mozilla.gecko.widget.AnchoredPopup;
import android.animation.Animator;
import android.animation.ObjectAnimator;
import android.annotation.SuppressLint;
import android.annotation.TargetApi;
import android.app.Activity;
import android.app.AlertDialog;
import android.content.Context;
@@ -103,19 +106,16 @@ import android.widget.ListView;
import android.widget.RelativeLayout;
import android.widget.SimpleAdapter;
import android.widget.TextView;
import android.widget.Toast;
import org.json.JSONArray;
import org.json.JSONException;
import org.json.JSONObject;
-import org.mozilla.gecko.util.ViewUtil;
-import org.mozilla.gecko.widget.AnchoredPopup;
-import org.mozilla.gecko.widget.ActionModePresenter;
import java.io.ByteArrayOutputStream;
import java.io.File;
import java.io.IOException;
import java.io.InputStream;
import java.lang.ref.WeakReference;
import java.net.URL;
import java.util.ArrayList;
@@ -156,17 +156,17 @@ public abstract class GeckoApp
public static final String INTENT_REGISTER_STUMBLER_LISTENER = "org.mozilla.gecko.STUMBLER_REGISTER_LOCAL_LISTENER";
public static final String EXTRA_STATE_BUNDLE = "stateBundle";
public static final String LAST_SELECTED_TAB = "lastSelectedTab";
public static final String PREFS_ALLOW_STATE_BUNDLE = "allowStateBundle";
- public static final String PREFS_FLASH_USAGE = "playFlashCount";
+ public static final String PREFS_FLASH_USAGE = "playFlashCount";
public static final String PREFS_VERSION_CODE = "versionCode";
public static final String PREFS_WAS_STOPPED = "wasStopped";
public static final String PREFS_CRASHED_COUNT = "crashedCount";
public static final String PREFS_CLEANUP_TEMP_FILES = "cleanupTempFiles";
// Originally, this was only used for the telemetry core ping logic. To avoid
// having to write custom migration logic, we just keep the original pref key.
public static final String PREFS_IS_FIRST_RUN = "telemetry-isFirstRun";
--- a/mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java
+++ b/mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java
@@ -47,16 +47,18 @@ import org.mozilla.gecko.util.Clipboard;
import org.mozilla.gecko.util.ColorUtil;
import org.mozilla.gecko.util.GeckoBundle;
import org.mozilla.gecko.util.IntentUtils;
import org.mozilla.gecko.widget.ActionModePresenter;
import org.mozilla.gecko.widget.GeckoPopupMenu;
import java.util.List;
+import static org.mozilla.gecko.Tabs.TabEvents;
+
public class CustomTabsActivity extends GeckoApp implements Tabs.OnTabsChangedListener {
private static final String LOGTAG = "CustomTabsActivity";
private static final String SAVED_START_INTENT = "saved_intent_which_started_this_activity";
private final SparseArrayCompat<PendingIntent> menuItemsIntent = new SparseArrayCompat<>();
private GeckoPopupMenu popupMenu;
private View doorhangerOverlay;
private ActionBarPresenter actionBarPresenter;
@@ -187,35 +189,35 @@ public class CustomTabsActivity extends
}
@Override
protected void onDone() {
finish();
}
@Override
- public void onTabChanged(Tab tab, Tabs.TabEvents msg, String data) {
+ public void onTabChanged(Tab tab, TabEvents msg, String data) {
if (!Tabs.getInstance().isSelectedTab(tab)) {
return;
}
- if (msg == Tabs.TabEvents.START
- || msg == Tabs.TabEvents.STOP
- || msg == Tabs.TabEvents.ADDED
- || msg == Tabs.TabEvents.LOAD_ERROR
- || msg == Tabs.TabEvents.LOADED
- || msg == Tabs.TabEvents.LOCATION_CHANGE) {
+ if (msg == TabEvents.START
+ || msg == TabEvents.STOP
+ || msg == TabEvents.ADDED
+ || msg == TabEvents.LOAD_ERROR
+ || msg == TabEvents.LOADED
+ || msg == TabEvents.LOCATION_CHANGE) {
updateProgress((tab.getState() == Tab.STATE_LOADING),
tab.getLoadProgress());
}
- if (msg == Tabs.TabEvents.LOCATION_CHANGE
- || msg == Tabs.TabEvents.SECURITY_CHANGE
- || msg == Tabs.TabEvents.TITLE) {
+ if (msg == TabEvents.LOCATION_CHANGE
+ || msg == TabEvents.SECURITY_CHANGE
+ || msg == TabEvents.TITLE) {
actionBarPresenter.update(tab);
}
updateMenuItemForward();
}
@Override
protected void onSaveInstanceState(Bundle outState) {
--- a/mobile/android/base/java/org/mozilla/gecko/webapps/WebAppActivity.java
+++ b/mobile/android/base/java/org/mozilla/gecko/webapps/WebAppActivity.java
@@ -7,17 +7,16 @@ package org.mozilla.gecko.webapps;
import java.io.File;
import java.io.IOException;
import android.app.ActivityManager;
import android.content.Intent;
import android.graphics.Bitmap;
import android.net.Uri;
-import android.os.Build;
import android.os.Bundle;
import android.support.v7.widget.Toolbar;
import android.support.v7.app.ActionBar;
import android.util.Log;
import android.view.View;
import android.view.Window;
import android.view.WindowManager;
import android.widget.ProgressBar;
@@ -25,34 +24,31 @@ import android.widget.TextView;
import org.json.JSONObject;
import org.json.JSONException;
import org.mozilla.gecko.AppConstants;
import org.mozilla.gecko.EventDispatcher;
import org.mozilla.gecko.GeckoApp;
import org.mozilla.gecko.GeckoAppShell;
-import org.mozilla.gecko.GeckoProfile;
import org.mozilla.gecko.Telemetry;
import org.mozilla.gecko.TelemetryContract;
import org.mozilla.gecko.icons.decoders.FaviconDecoder;
import org.mozilla.gecko.icons.decoders.LoadFaviconResult;
import org.mozilla.gecko.mozglue.SafeIntent;
import org.mozilla.gecko.R;
import org.mozilla.gecko.Tab;
import org.mozilla.gecko.Tabs;
import org.mozilla.gecko.util.ColorUtil;
import org.mozilla.gecko.util.EventCallback;
import org.mozilla.gecko.util.FileUtils;
import org.mozilla.gecko.util.GeckoBundle;
import org.mozilla.gecko.widget.AnchoredPopup;
public class WebAppActivity extends GeckoApp {
-
- public static final String INTENT_KEY = "IS_A_WEBAPP";
public static final String MANIFEST_PATH = "MANIFEST_PATH";
private static final String LOGTAG = "WebAppActivity";
private TextView mUrlView;
private View doorhangerOverlay;
private String mManifestPath;