Bug 1322650 - Don't use inout param for Surface in ICodec r=jolin draft
authorJames Willcox <snorp@snorp.net>
Fri, 03 Mar 2017 15:19:04 -0600
changeset 557636 2756d48ab9b351b2bfef1ce005847f6d9bb681e2
parent 557635 7d54ff3802120a271a61cc2855831933e54d5539
child 557637 b6b7cb898bb5a3676dcdbe05a93893491908d735
push id52769
push userbmo:snorp@snorp.net
push dateFri, 07 Apr 2017 02:38:28 +0000
reviewersjolin
bugs1322650
milestone55.0a1
Bug 1322650 - Don't use inout param for Surface in ICodec r=jolin It's unnecessary, and the serialization goes wrong with GeckoSurface on the return trip. MozReview-Commit-ID: 9DUMoLQFhlv
mobile/android/geckoview/src/main/aidl/org/mozilla/gecko/media/ICodec.aidl
--- a/mobile/android/geckoview/src/main/aidl/org/mozilla/gecko/media/ICodec.aidl
+++ b/mobile/android/geckoview/src/main/aidl/org/mozilla/gecko/media/ICodec.aidl
@@ -8,17 +8,17 @@ package org.mozilla.gecko.media;
 import android.os.Bundle;
 import android.view.Surface;
 import org.mozilla.gecko.media.FormatParam;
 import org.mozilla.gecko.media.ICodecCallbacks;
 import org.mozilla.gecko.media.Sample;
 
 interface ICodec {
     void setCallbacks(in ICodecCallbacks callbacks);
-    boolean configure(in FormatParam format, inout Surface surface, int flags, in String drmStubId);
+    boolean configure(in FormatParam format, in Surface surface, int flags, in String drmStubId);
     boolean isAdaptivePlaybackSupported();
     void start();
     void stop();
     void flush();
     void release();
 
     Sample dequeueInput(int size);
     oneway void queueInput(in Sample sample);