Bug 1311257 - Update comment refering to bug 1311257. r?birtles draft
authorHiroyuki Ikezoe <hikezoe@mozilla.com>
Thu, 06 Apr 2017 11:51:29 +0900
changeset 556571 b7491b6ba7fe81b6bad45a9aa68088bdd21f1640
parent 556570 3a645d8c0dc223cb6c2d9d0434409ae324c73f18
child 622923 7e8538c324c88edc6e26f09e0ac6dff06f777329
push id52584
push userhikezoe@mozilla.com
push dateThu, 06 Apr 2017 03:01:12 +0000
reviewersbirtles
bugs1311257
milestone55.0a1
Bug 1311257 - Update comment refering to bug 1311257. r?birtles MozReview-Commit-ID: EM1dYILDlzS
layout/base/nsLayoutUtils.cpp
layout/painting/nsDisplayList.cpp
layout/style/nsComputedDOMStyle.cpp
--- a/layout/base/nsLayoutUtils.cpp
+++ b/layout/base/nsLayoutUtils.cpp
@@ -590,17 +590,17 @@ GetMinAndMaxScaleForAnimationProperty(co
       if (prop.mProperty != eCSSProperty_transform) {
         continue;
       }
 
       // We need to factor in the scale of the base style if the base style
       // will be used on the compositor.
       StyleAnimationValue baseStyle = effect->BaseStyle(prop.mProperty);
       if (!baseStyle.IsNull()) {
-        // FIXME: Bug 1311257: We need to get the baseStyle for
+        // FIXME: Bug 1334036: We need to get the baseStyle for
         //        RawServoAnimationValue.
         UpdateMinMaxScale(aFrame, { baseStyle, nullptr }, aMinScale, aMaxScale);
       }
 
       for (const AnimationPropertySegment& segment : prop.mSegments) {
         // In case of add or accumulate composite, StyleAnimationValue does
         // not have a valid value.
         if (segment.HasReplaceableFromValue()) {
--- a/layout/painting/nsDisplayList.cpp
+++ b/layout/painting/nsDisplayList.cpp
@@ -553,17 +553,17 @@ AddAnimationForProperty(nsIFrame* aFrame
   TransformReferenceBox refBox(aFrame);
 
   // If the animation is additive or accumulates, we need to pass its base value
   // to the compositor.
 
   StyleAnimationValue baseStyle =
     aAnimation->GetEffect()->AsKeyframeEffect()->BaseStyle(aProperty.mProperty);
   if (!baseStyle.IsNull()) {
-    // FIXME: Bug 1311257: We need to get the baseValue for
+    // FIXME: Bug 1334036: We need to get the baseValue for
     //        RawServoAnimationValue.
     SetAnimatable(aProperty.mProperty,
                   { baseStyle, nullptr },
                   aFrame, refBox,
                   animation->baseStyle());
   } else {
     animation->baseStyle() = null_t();
   }
--- a/layout/style/nsComputedDOMStyle.cpp
+++ b/layout/style/nsComputedDOMStyle.cpp
@@ -531,17 +531,17 @@ public:
   already_AddRefed<nsStyleContext>
   ResolveWithoutAnimation(StyleSetHandle aStyleSet,
                           Element* aElement,
                           CSSPseudoElementType aType,
                           nsStyleContext* aParentContext,
                           bool aInDocWithShell)
   {
     MOZ_ASSERT(!aStyleSet->IsServo(),
-      "Bug 1311257: Servo backend does not support the base value yet");
+      "Servo backend should not use this function");
     MOZ_ASSERT(mAnimationFlag == nsComputedDOMStyle::eWithoutAnimation,
       "AnimationFlag should be eWithoutAnimation");
 
     RefPtr<nsStyleContext> result;
 
     if (aType != CSSPseudoElementType::NotPseudo) {
       nsIFrame* frame = nsLayoutUtils::GetStyleFrame(aElement);
       Element* pseudoElement =