Bug 1353074 - Test arguments in all sandboxes; r=maja_zf draft
authorAndreas Tolfsen <ato@mozilla.com>
Mon, 03 Apr 2017 19:15:13 +0100
changeset 567664 3983dfb2f14b740b100f4d8aa434b0e6a7e79e83
parent 567663 3a3b3757f2149e4a2e182be65c9049b0793cc702
child 567665 7d9c0650fa1a57730962e3e919d1723dc6866f90
push id55659
push userbmo:ato@mozilla.com
push dateTue, 25 Apr 2017 11:34:29 +0000
reviewersmaja_zf
bugs1353074
milestone55.0a1
Bug 1353074 - Test arguments in all sandboxes; r=maja_zf We were previously missing a test for the arguments variable that is implicitly exposed to functions. MozReview-Commit-ID: IC6aJcUsyhd
testing/marionette/harness/marionette_harness/tests/unit/test_execute_script.py
--- a/testing/marionette/harness/marionette_harness/tests/unit/test_execute_script.py
+++ b/testing/marionette/harness/marionette_harness/tests/unit/test_execute_script.py
@@ -87,17 +87,28 @@ class TestExecuteContent(MarionetteTestC
         self.assertEqual(
             {"foo": {"bar": [1, 2]}},
             self.marionette.execute_script("return {foo: {bar: [1, 2]}}"))
 
     def test_no_return_value(self):
         self.assertIsNone(self.marionette.execute_script("true"))
 
     def test_argument_null(self):
-        self.assertIsNone(self.marionette.execute_script("return arguments[0]", [None]))
+        self.assertIsNone(self.marionette.execute_script(
+            "return arguments[0]",
+            script_args=(None,),
+            sandbox="default"))
+        self.assertIsNone(self.marionette.execute_script(
+            "return arguments[0]",
+            script_args=(None,),
+            sandbox="system"))
+        self.assertIsNone(self.marionette.execute_script(
+            "return arguments[0]",
+            script_args=(None,),
+            sandbox=None))
 
     def test_argument_number(self):
         self.assertEqual(
             1, self.marionette.execute_script("return arguments[0]", (1,)))
         self.assertEqual(
             1.5, self.marionette.execute_script("return arguments[0]", (1.5,)))
 
     def test_argument_boolean(self):