Bug 1352464. Fix preshints to not get applied to pseudo-elements in stylo. r?manishearth draft
authorBoris Zbarsky <bzbarsky@mit.edu>
Fri, 31 Mar 2017 12:37:49 -0400
changeset 554475 25c44da8d04d08aaf1a1927182506052e7d2422e
parent 554422 13f5ae940c4eb099b987484885f9edf71ed0380b
child 622343 234a71d11fbaa2fcda982317242ee226c82be27a
push id51940
push userbzbarsky@mozilla.com
push dateFri, 31 Mar 2017 16:37:59 +0000
reviewersmanishearth
bugs1352464
milestone55.0a1
Bug 1352464. Fix preshints to not get applied to pseudo-elements in stylo. r?manishearth MozReview-Commit-ID: 61D2cJkrseT
layout/reftests/bugs/1352464-1-ref.html
layout/reftests/bugs/1352464-1.html
layout/reftests/bugs/reftest-stylo.list
layout/reftests/bugs/reftest.list
layout/style/test/stylo-failures.md
new file mode 100644
--- /dev/null
+++ b/layout/reftests/bugs/1352464-1-ref.html
@@ -0,0 +1,9 @@
+<!DOCTYPE html>
+<style>
+  td::before { content: "Test"; display: inline-block; border: 3px solid black }
+</style>
+<table>
+  <tr>
+    <td style="width: 300px"></td>
+  </tr>
+</table>
new file mode 100644
--- /dev/null
+++ b/layout/reftests/bugs/1352464-1.html
@@ -0,0 +1,9 @@
+<!DOCTYPE html>
+<style>
+  td::before { content: "Test"; display: inline-block; border: 3px solid black }
+</style>
+<table>
+  <tr>
+    <td width="300"></td>
+  </tr>
+</table>
--- a/layout/reftests/bugs/reftest-stylo.list
+++ b/layout/reftests/bugs/reftest-stylo.list
@@ -1984,10 +1984,9 @@ fails == 1316719-1b.html 1316719-1b.html
 fails == 1316719-1c.html 1316719-1c.html
 
 HTTP == 652991-1a.html 652991-1a.html
 HTTP == 652991-1b.html 652991-1b.html
 HTTP == 652991-2.html 652991-2.html
 HTTP == 652991-3.html 652991-3.html
 fails HTTP == 652991-4.html 652991-4.html
 == 1330051.svg 1330051.svg
-
-
+== 1352464-1.html 1352464-1.html
--- a/layout/reftests/bugs/reftest.list
+++ b/layout/reftests/bugs/reftest.list
@@ -1985,8 +1985,9 @@ fuzzy(2,320000) == 1315113-1.html 131511
 fuzzy(2,20000) == 1315113-2.html 1315113-2-ref.html
 == 1315632-1.html 1315632-1-ref.html
 fuzzy(2,40000) == 1316719-1a.html 1316719-1-ref.html
 fuzzy(2,40000) == 1316719-1b.html 1316719-1-ref.html
 fuzzy(2,40000) == 1316719-1c.html 1316719-1-ref.html
 skip-if(Android) != 1318769-1.html 1318769-1-ref.html
 == 1322512-1.html 1322512-1-ref.html
 == 1330051.svg 1330051-ref.svg
+== 1352464-1.html 1352464-1-ref.html
--- a/layout/style/test/stylo-failures.md
+++ b/layout/style/test/stylo-failures.md
@@ -440,16 +440,15 @@ to mochitest command.
 
 ## Unknown / Unsure
 
 * test_additional_sheets.html: one sub-test cascade order is wrong [1]
 * test_flexbox_layout.html: resolved width doesn't match expectation [5]
 * test_selectors.html `:nth-child`: &lt;an+b&gt; parsing difference [14]
 * test_selectors_on_anonymous_content.html: xbl and :nth-child [1]
 * test_variables.html `url`: url in custom property [1]
-* test_pseudoelement_state.html: doesn't seem to work at all, but only range-thumb fails... [4]
 * test_parse_rule.html `rgb(0, 128, 0)`: color properties not getting computed [6]
 
 ## Ignore
 
 * Ignore for now since should be mostly identical to test_value_storage.html
   * test_value_cloning.html [*]
   * test_value_computation.html [*]