Bug 1351777 - Remove unnecessary cast and more tightly scope a local var. r?dvander draft
authorKartikaya Gupta <kgupta@mozilla.com>
Fri, 31 Mar 2017 11:43:21 -0400
changeset 554460 719063ad2b1e545696887945e94fb376f547a402
parent 554459 fff584f70bd7d01735bfc2f4d0e06f69aa0fc1c6
child 554461 e398b8ee5c261c35d63938d3144284638f95a765
push id51931
push userkgupta@mozilla.com
push dateFri, 31 Mar 2017 15:44:23 +0000
reviewersdvander
bugs1351777
milestone55.0a1
Bug 1351777 - Remove unnecessary cast and more tightly scope a local var. r?dvander MozReview-Commit-ID: JEfQOdQ2HNJ
dom/ipc/TabParent.cpp
--- a/dom/ipc/TabParent.cpp
+++ b/dom/ipc/TabParent.cpp
@@ -2485,27 +2485,25 @@ TabParent::DeallocPColorPickerParent(PCo
   return true;
 }
 
 PRenderFrameParent*
 TabParent::AllocPRenderFrameParent()
 {
   MOZ_ASSERT(ManagedPRenderFrameParent().IsEmpty());
   RefPtr<nsFrameLoader> frameLoader = GetFrameLoader();
-  uint64_t layersId = 0;
   bool success = false;
 
-  PRenderFrameParent* renderFrame =
+  RenderFrameParent* rfp =
     new RenderFrameParent(frameLoader, &success);
   if (success) {
-    RenderFrameParent* rfp = static_cast<RenderFrameParent*>(renderFrame);
-    layersId = rfp->GetLayersId();
+    uint64_t layersId = rfp->GetLayersId();
     AddTabParentToTable(layersId, this);
   }
-  return renderFrame;
+  return rfp;
 }
 
 bool
 TabParent::DeallocPRenderFrameParent(PRenderFrameParent* aFrame)
 {
   delete aFrame;
   return true;
 }