Bug 1351896 - Fix Android JNI error while running android native vp8 encoder; r?jolin draft
authorMunro Mengjue Chiang <mchiang@mozilla.com>
Fri, 03 Feb 2017 12:01:57 +0800
changeset 553377 ff91d2f20d5fbc132b7f5c53fd2a88dd52b7619a
parent 553172 6ea713ccc9abea93126423fefb855d0e051c95e2
child 622049 570faa6249698331894820242250ea1eaba14176
push id51618
push userbmo:mchiang@mozilla.com
push dateWed, 29 Mar 2017 23:09:33 +0000
reviewersjolin
bugs1351896
milestone55.0a1
Bug 1351896 - Fix Android JNI error while running android native vp8 encoder; r?jolin MozReview-Commit-ID: Gm9WwfgMjh8
media/webrtc/signaling/src/media-conduit/WebrtcMediaCodecVP8VideoCodec.cpp
--- a/media/webrtc/signaling/src/media-conduit/WebrtcMediaCodecVP8VideoCodec.cpp
+++ b/media/webrtc/signaling/src/media-conduit/WebrtcMediaCodecVP8VideoCodec.cpp
@@ -455,40 +455,32 @@ public:
 
   void ReleaseOutputBuffer(int32_t index, bool flag) {
     mCoder->ReleaseOutputBuffer(index, flag);
   }
 
   jobjectArray GetInputBuffers() {
     JNIEnv* env = jsjni_GetJNIForThread();
 
-    if (mInputBuffers) {
-      env->DeleteGlobalRef(mInputBuffers);
-    }
-
     nsresult res;
     jni::ObjectArray::LocalRef inputBuffers;
     res = mCoder->GetInputBuffers(&inputBuffers);
     mInputBuffers = (jobjectArray) env->NewGlobalRef(inputBuffers.Get());
     if (NS_FAILED(res)) {
       CSFLogDebug(logTag, "WebrtcAndroidMediaCodec::%s, GetInputBuffers return err = %d",
                   __FUNCTION__, (int)res);
       return nullptr;
     }
 
     return mInputBuffers;
   }
 
   jobjectArray GetOutputBuffers() {
     JNIEnv* env = jsjni_GetJNIForThread();
 
-    if (mOutputBuffers) {
-      env->DeleteGlobalRef(mOutputBuffers);
-    }
-
     nsresult res;
     jni::ObjectArray::LocalRef outputBuffers;
     res = mCoder->GetOutputBuffers(&outputBuffers);
     mOutputBuffers = (jobjectArray) env->NewGlobalRef(outputBuffers.Get());
     if (NS_FAILED(res)) {
       CSFLogDebug(logTag, "WebrtcAndroidMediaCodec::%s, GetOutputBuffers return err = %d",
                   __FUNCTION__, (int)res);
       return nullptr;