Bug 1351385, part 1 - Rename JSON viewer things in preparation for a move to another file. r=Honza draft
authorAndrew McCreight <continuation@gmail.com>
Tue, 28 Mar 2017 08:45:03 -0700
changeset 553221 d257ad6ed35b3cc7ca436c4e59d17fd3bbfe8d8c
parent 553214 942d678ad5a37a1df16829385e3603de1a9d53f5
child 553222 01159322ad01fa4e863c01e29d4f2333405f94e3
child 553743 3d2e225c8ee1a82f7c7fdd16c9193e73729a3e3b
push id51555
push userbmo:continuation@gmail.com
push dateWed, 29 Mar 2017 15:58:12 +0000
reviewersHonza
bugs1351385
milestone55.0a1
Bug 1351385, part 1 - Rename JSON viewer things in preparation for a move to another file. r=Honza MozReview-Commit-ID: 1jj5VEELkrv
devtools/client/jsonview/converter-child.js
--- a/devtools/client/jsonview/converter-child.js
+++ b/devtools/client/jsonview/converter-child.js
@@ -24,20 +24,20 @@ const childProcessMessageManager =
   Cc["@mozilla.org/childprocessmessagemanager;1"]
     .getService(Ci.nsISyncMessageSender);
 
 // Amount of space that will be allocated for the stream's backing-store.
 // Must be power of 2. Used to copy the data stream in onStopRequest.
 const SEGMENT_SIZE = Math.pow(2, 17);
 
 const JSON_VIEW_MIME_TYPE = "application/vnd.mozilla.json.view";
-const CONTRACT_ID = "@mozilla.org/streamconv;1?from=" +
+const JSON_VIEW_CONTRACT_ID = "@mozilla.org/streamconv;1?from=" +
   JSON_VIEW_MIME_TYPE + "&to=*/*";
-const CLASS_ID = components.ID("{d8c9acee-dec5-11e4-8c75-1681e6b88ec1}");
-const CLASS_DESCRIPTION = "JSONView converter";
+const JSON_VIEW_CLASS_ID = components.ID("{d8c9acee-dec5-11e4-8c75-1681e6b88ec1}");
+const JSON_VIEW_CLASS_DESCRIPTION = "JSONView converter";
 
 // Localization
 loader.lazyGetter(this, "jsonViewStrings", () => {
   return Services.strings.createBundle(
     "chrome://devtools/locale/jsonview.properties");
 });
 
 /**
@@ -322,40 +322,44 @@ Converter.prototype = {
       let header = requestHeaders[i];
       value += header.name + ": " + header.value + eol;
     }
 
     Clipboard.set(value, "text");
   }
 };
 
-const Factory = {
+function createInstance() {
+  return new Converter();
+}
+
+const JsonViewFactory = {
   createInstance: function (outer, iid) {
     if (outer) {
       throw Cr.NS_ERROR_NO_AGGREGATION;
     }
-    return new Converter();
+    return createInstance();
   }
 };
 
 function register() {
-  if (!registrar.isCIDRegistered(CLASS_ID)) {
-    registrar.registerFactory(CLASS_ID,
-      CLASS_DESCRIPTION,
-      CONTRACT_ID,
-      Factory);
+  if (!registrar.isCIDRegistered(JSON_VIEW_CLASS_ID)) {
+    registrar.registerFactory(JSON_VIEW_CLASS_ID,
+      JSON_VIEW_CLASS_DESCRIPTION,
+      JSON_VIEW_CONTRACT_ID,
+      JsonViewFactory);
     return true;
   }
 
   return false;
 }
 
 function unregister() {
-  if (registrar.isCIDRegistered(CLASS_ID)) {
-    registrar.unregisterFactory(CLASS_ID, Factory);
+  if (registrar.isCIDRegistered(JSON_VIEW_CLASS_ID)) {
+    registrar.unregisterFactory(JSON_VIEW_CLASS_ID, JsonViewFactory);
     return true;
   }
   return false;
 }
 
 exports.JsonViewService = {
   register: register,
   unregister: unregister