Bug 1351335 - Don't close software update dialog before restart. draft
authorHenrik Skupin <mail@hskupin.info>
Wed, 29 Mar 2017 10:42:55 +0200
changeset 552937 163068494b7db31a0db9fde0f6f06236fe55a48c
parent 551502 cc53710589fb500610495da5258b7b9221edf681
child 621953 daea1c81c7637c7a686151dc2f426c22c4fde136
push id51515
push userbmo:hskupin@gmail.com
push dateWed, 29 Mar 2017 08:45:16 +0000
bugs1351335
milestone55.0a1
Bug 1351335 - Don't close software update dialog before restart. There is no need to close this dialog given that a restart happens anyway. But doing that as right now, and trying to invoke execute_script() on it, will end up with a unlocatable window. MozReview-Commit-ID: 53yBLYsWX4o
testing/firefox-ui/harness/firefox_ui_harness/testcases.py
--- a/testing/firefox-ui/harness/firefox_ui_harness/testcases.py
+++ b/testing/firefox-ui/harness/firefox_ui_harness/testcases.py
@@ -317,17 +317,16 @@ class UpdateTestCase(PuppeteerMixin, Mar
 
         else:
             try:
                 self.assertEqual(dialog.wizard.selected_panel,
                                  dialog.wizard.error_patching)
 
                 # Start downloading the fallback update
                 self.download_update(dialog)
-                dialog.close()
 
             finally:
                 self.updates[self.current_update_index]['patch'] = self.patch_info
 
         # Restart Firefox to apply the update
         self.restart()
 
     def read_update_log(self):