Bug 1350887 - Warn when non-loopback connections are allowed; r=whimboo draft
authorAndreas Tolfsen <ato@mozilla.com>
Tue, 28 Mar 2017 17:06:06 +0100
changeset 556070 eebaa080da264b27ab73af7456e95e560303f6d6
parent 556069 4a604a224db9e4106f6da1e898f33195c6fc82d2
child 622777 a0c5390cff4d06a0f67ef5c5c3ece6298dcd6084
push id52427
push userbmo:ato@mozilla.com
push dateWed, 05 Apr 2017 09:39:48 +0000
reviewerswhimboo
bugs1350887
milestone55.0a1
Bug 1350887 - Warn when non-loopback connections are allowed; r=whimboo MozReview-Commit-ID: LG8f5q5QbD6
testing/marionette/server.js
--- a/testing/marionette/server.js
+++ b/testing/marionette/server.js
@@ -319,16 +319,18 @@ server.TCPListener = class {
           this.alteredPrefs.add(k);
         }
       }
     }
 
     let flags = Ci.nsIServerSocket.KeepWhenOffline;
     if (this.forceLocal) {
       flags |= Ci.nsIServerSocket.LoopbackOnly;
+    } else {
+      logger.warn("Server socket is not limited to loopback connections");
     }
     this.listener = new ServerSocket(this.port, flags, 1);
     this.listener.asyncListen(this);
 
     this.alive = true;
     this._acceptConnections = true;
   }