Bug 1343589 - Add comments to test_animation_observers_[a]sync.html to describe how they differ draft
authorBrian Birtles <birtles@gmail.com>
Tue, 28 Mar 2017 14:51:52 +0900
changeset 552216 0f2028418b5ce0b1475d74ad84a330e1f0a2f6bf
parent 552215 f189d4c0dd40ca70396cfa6565cbd6ae768fa17d
child 552217 de0b5ecb3ffc18fd31ac326ac0d75a28a4e12125
child 552223 e562d64a4543e2359a9c79bc1c30bc6206b71ca2
push id51290
push userbbirtles@mozilla.com
push dateTue, 28 Mar 2017 05:52:19 +0000
bugs1343589
milestone55.0a1
Bug 1343589 - Add comments to test_animation_observers_[a]sync.html to describe how they differ MozReview-Commit-ID: HxhsaOKDAsq
dom/animation/test/chrome/test_animation_observers_async.html
dom/animation/test/chrome/test_animation_observers_sync.html
--- a/dom/animation/test/chrome/test_animation_observers_async.html
+++ b/dom/animation/test/chrome/test_animation_observers_async.html
@@ -1,11 +1,23 @@
 <!DOCTYPE html>
 <meta charset=utf-8>
-<title>Test chrome-only MutationObserver animation notifications</title>
+<title>
+Test chrome-only MutationObserver animation notifications (async tests)
+</title>
+<!--
+
+  This file contains tests for animation mutation observers that require
+  some asynchronous steps (e.g. waiting for animation events).
+
+  Where possible, however, we prefer to write synchronous tests since they are
+  less to timeout when run on automation. These synchronous tests are located
+  in test_animation_observers_sync.html.
+
+-->
 <script src="chrome://mochikit/content/tests/SimpleTest/SimpleTest.js"></script>
 <script src="chrome://mochikit/content/tests/SimpleTest/EventUtils.js"></script>
 <script src="../testcommon.js"></script>
 <link rel="stylesheet" type="text/css" href="chrome://mochikit/content/tests/SimpleTest/test.css">
 <style>
 @keyframes anim {
   to { transform: translate(100px); }
 }
--- a/dom/animation/test/chrome/test_animation_observers_sync.html
+++ b/dom/animation/test/chrome/test_animation_observers_sync.html
@@ -1,13 +1,23 @@
 <!DOCTYPE html>
 <meta charset=utf-8>
 <title>
-Test chrome-only MutationObserver animation notifications for sync APIs
+Test chrome-only MutationObserver animation notifications (sync tests)
 </title>
+<!--
+
+  This file contains synchronous tests for animation mutation observers.
+
+  In general we prefer to write synchronous tests since they are less likely to
+  timeout when run on automation. Tests that require asynchronous steps (e.g.
+  waiting on events) should be added to test_animations_observers_async.html
+  instead.
+
+-->
 <script type="application/javascript" src="../testharness.js"></script>
 <script type="application/javascript" src="../testharnessreport.js"></script>
 <script type="application/javascript" src="../testcommon.js"></script>
 <div id="log"></div>
 <style>
 @keyframes anim {
   to { transform: translate(100px); }
 }