Bug 1347493 - Correctly assign a value to 'title' for phishing and malware sites r?johannh draft
authorBianca Danforth <biancadanforth@gmail.com>
Sun, 26 Mar 2017 12:47:50 -0700
changeset 552704 dbbf26e964b4717b5cbc5fab47cc9d784152043a
parent 504632 4c987b7ed54a630a7de76adcc2eb00dab49d5dfd
child 621882 998451c768f0c9d8234f25c5e5e79055aa15c12b
push id51427
push userbmo:biancadanforth@gmail.com
push dateTue, 28 Mar 2017 21:11:34 +0000
reviewersjohannh
bugs1347493
milestone55.0a1
Bug 1347493 - Correctly assign a value to 'title' for phishing and malware sites r?johannh MozReview-Commit-ID: KiEOLdLjuI5
browser/base/content/browser.js
--- a/browser/base/content/browser.js
+++ b/browser/base/content/browser.js
@@ -3177,31 +3177,31 @@ var BrowserOnClick = {
       label: gNavigatorBundle.getString("safebrowsing.getMeOutOfHereButton.label"),
       accessKey: gNavigatorBundle.getString("safebrowsing.getMeOutOfHereButton.accessKey"),
       callback() { getMeOutOfHere(); }
     }];
 
     let title;
     if (reason === "malware") {
       let reportUrl = gSafeBrowsing.getReportURL("MalwareMistake", blockedInfo);
-
+      title = gNavigatorBundle.getString("safebrowsing.reportedAttackSite");
       // There's no button if we can not get report url, for example if the provider
       // of blockedInfo is not Google
       if (reportUrl) {
         buttons[1] = {
           label: gNavigatorBundle.getString("safebrowsing.notAnAttackButton.label"),
           accessKey: gNavigatorBundle.getString("safebrowsing.notAnAttackButton.accessKey"),
           callback() {
             openUILinkIn(reportUrl, "tab");
           }
         };
       }
     } else if (reason === "phishing") {
       let reportUrl = gSafeBrowsing.getReportURL("PhishMistake", blockedInfo);
-
+      title = gNavigatorBundle.getString("safebrowsing.deceptiveSite");
       // There's no button if we can not get report url, for example if the provider
       // of blockedInfo is not Google
       if (reportUrl) {
         buttons[1] = {
           label: gNavigatorBundle.getString("safebrowsing.notADeceptiveSiteButton.label"),
           accessKey: gNavigatorBundle.getString("safebrowsing.notADeceptiveSiteButton.accessKey"),
           callback() {
             openUILinkIn(reportUrl, "tab");