Bug 1344016 - Update styling of about:debugging for add-ons r?jdescottes draft
authorMark Striemer <mstriemer@mozilla.com>
Wed, 05 Apr 2017 16:35:44 -0500
changeset 557277 7cb4c727a820415504829a2226ab0bc1cc049de7
parent 556400 eb56d0860cb693244f99d18c9e2a88d71c98c85e
child 623004 bd967209f91578fb6c5b13b266905fbad8b3a9a3
push id52667
push userbmo:mstriemer@mozilla.com
push dateThu, 06 Apr 2017 15:39:15 +0000
reviewersjdescottes
bugs1344016
milestone55.0a1
Bug 1344016 - Update styling of about:debugging for add-ons r?jdescottes MozReview-Commit-ID: CGCoX6mtuv4
devtools/client/aboutdebugging/aboutdebugging.css
devtools/client/aboutdebugging/components/addons/target.js
--- a/devtools/client/aboutdebugging/aboutdebugging.css
+++ b/devtools/client/aboutdebugging/aboutdebugging.css
@@ -209,8 +209,83 @@ button {
   flex-direction: column;
   width: 100%;
   height: 100%;
 }
 
 .error-page .error-page-details {
   color: gray;
 }
+
+.addon-target-container {
+  background: #fff;
+  box-shadow: 0 0 1px rgba(0, 0, 0, 0.12);
+  list-style-type: none;
+  margin: 0 0 8px;
+  padding: 4px 16px;
+  transition: box-shadow 150ms;
+}
+
+.addon-target-container:hover {
+  box-shadow: 0 1px 2px rgba(0, 0, 0, 0.24);
+}
+
+.addon-target-container .target {
+  align-items: center;
+  display: flex;
+  margin: 0;
+  padding: 16px 0;
+}
+
+.addon-target-actions {
+  border-top: 1px solid rgba(0, 0, 0, 0.2);
+}
+
+.addon-target-container .target-icon {
+  margin-inline-end: 16px;
+}
+
+.addon-target-container .name {
+  align-self: center;
+  font-size: 16px;
+  font-weight: 600;
+}
+
+.addon-target-button {
+  background: none;
+  border: none;
+  color: #0087ff;
+  font-size: 14px;
+  margin: 12px;
+  min-width: auto;
+  padding: 4px;
+  transition: color 150ms;
+}
+
+.addon-target-button:active,
+.addon-target-button:hover,
+.addon-target-button:enabled:hover:active {
+  background: none;
+}
+
+.addon-target-button:disabled {
+  color: #999;
+  opacity: 1;
+}
+
+.addon-target-button:enabled:focus,
+.addon-target-button:enabled:hover {
+  background: none;
+  color: #0052cc;
+  cursor: pointer;
+  text-decoration: underline;
+}
+
+.addon-target-button:enabled:hover:active {
+  color: #003399;
+  text-decoration: none;
+}
+
+.addon-target-button:first-of-type {
+  /* Subtract the start padding so the button is still a bigger click target but
+   * lines up with the icon. */
+  margin-inline-start: -4px;
+}
--- a/devtools/client/aboutdebugging/components/addons/target.js
+++ b/devtools/client/aboutdebugging/components/addons/target.js
@@ -54,32 +54,34 @@ module.exports = createClass({
   },
 
   render() {
     let { target, debugDisabled } = this.props;
     // Only temporarily installed add-ons can be reloaded.
     const canBeReloaded = target.temporarilyInstalled;
 
     return dom.li(
-      { className: "target-container", "data-addon-id": target.addonID },
-      dom.img({
-        className: "target-icon",
-        role: "presentation",
-        src: target.icon
-      }),
+      { className: "addon-target-container", "data-addon-id": target.addonID },
       dom.div({ className: "target" },
-        dom.div({ className: "target-name", title: target.name }, target.name)
+        dom.img({
+          className: "target-icon",
+          role: "presentation",
+          src: target.icon
+        }),
+        dom.span({ className: "target-name", title: target.name }, target.name)
       ),
-      dom.button({
-        className: "debug-button",
-        onClick: this.debug,
-        disabled: debugDisabled,
-      }, Strings.GetStringFromName("debug")),
-      dom.button({
-        className: "reload-button",
-        onClick: this.reload,
-        disabled: !canBeReloaded,
-        title: !canBeReloaded ?
-          Strings.GetStringFromName("reloadDisabledTooltip") : ""
-      }, Strings.GetStringFromName("reload"))
+      dom.div({className: "addon-target-actions"},
+        dom.button({
+          className: "debug-button addon-target-button",
+          onClick: this.debug,
+          disabled: debugDisabled,
+        }, Strings.GetStringFromName("debug")),
+        dom.button({
+          className: "reload-button addon-target-button",
+          onClick: this.reload,
+          disabled: !canBeReloaded,
+          title: !canBeReloaded ?
+            Strings.GetStringFromName("reloadDisabledTooltip") : ""
+        }, Strings.GetStringFromName("reload"))
+      ),
     );
   }
 });